表記ゆれアダプタのリファクタ: PR作成時にベンチマークテストが走るように設定 #55
Annotations
1 error and 2 warnings
|
Run benchmark
Unhanded error:
Error: The process '/home/runner/.cargo/bin/cargo' failed with exit code 101
|
|
The following actions use a deprecated Node.js version and will be forced to run on node20: giraffate/clippy-action@v1, boa-dev/criterion-compare-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Code review with clippy:
wasm/src/lib.rs#L42
[clippy] reported by reviewdog 🐶
<pre><code>warning: you should consider adding a `Default` implementation for `Parser`
--> wasm/src/lib.rs:42:5
|
42 | / pub fn new() -> Self {
43 | | #[cfg(feature = "debug")]
44 | | console_error_panic_hook::set_once();
45 | | Parser {
46 | | async_api: Arc::new(Default::default()),
47 | | }
48 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
note: the lint level is defined here
--> wasm/src/lib.rs:38:8
|
38 | #[warn(clippy::new_without_default)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: try adding this
|
40 + impl Default for Parser {
41 + fn default() -> Self {
42 + Self::new()
43 + }
44 + }
|
</code></pre>
Raw Output:
wasm/src/lib.rs:42:5:w:
<pre><code>warning: you should consider adding a `Default` implementation for `Parser`
--> wasm/src/lib.rs:42:5
|
42 | / pub fn new() -> Self {
43 | | #[cfg(feature = "debug")]
44 | | console_error_panic_hook::set_once();
45 | | Parser {
46 | | async_api: Arc::new(Default::default()),
47 | | }
48 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
note: the lint level is defined here
--> wasm/src/lib.rs:38:8
|
38 | #[warn(clippy::new_without_default)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: try adding this
|
40 + impl Default for Parser {
41 + fn default() -> Self {
42 + Self::new()
43 + }
44 + }
|
</code></pre>
__END__
|
Loading