chimei-ruiju.orgへの対応: experimental
モジュールのParser
でChimeiRuijuを使ってパースできるようにした
#127
Annotations
2 errors and 11 warnings
Code review with clippy
reviewdog: Too many results (annotations) in diff.
You may miss some annotations due to GitHub limitation for annotation created by logging command.
Please check GitHub Actions log console to see all results.
Limitation:
- 10 warning annotations and 10 error annotations per step
- 50 annotations per job (sum of annotations from all the steps)
- 50 annotations per run (separate from the job annotations, these annotations aren't created by users)
Source: https://github.com/orgs/community/discussions/26680#discussioncomment-3252835
|
Code review with clippy
reviewdog exited with status code: 1
|
The following actions use a deprecated Node.js version and will be forced to run on node20: giraffate/clippy-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Code review with clippy:
core/src/domain/chimei_ruiju/entity.rs#L4
[clippy] reported by reviewdog 🐶
<pre><code>warning: fields `name`, `cities`, and `coordinate` are never read
--> core/src/domain/chimei_ruiju/entity.rs:6:16
|
4 | pub struct PrefectureMaster {
| ---------------- fields in this struct
5 | /// 都道府県名
6 | pub(crate) name: String,
| ^^^^
7 | /// 市区町村名リスト
8 | pub(crate) cities: Vec<String>,
| ^^^^^^
9 | /// 代表点の緯度経度
10 | pub(crate) coordinate: Coordinate,
| ^^^^^^^^^^
|
= note: `PrefectureMaster` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
</code></pre>
Raw Output:
core/src/domain/chimei_ruiju/entity.rs:4:12:w:
<pre><code>warning: fields `name`, `cities`, and `coordinate` are never read
--> core/src/domain/chimei_ruiju/entity.rs:6:16
|
4 | pub struct PrefectureMaster {
| ---------------- fields in this struct
5 | /// 都道府県名
6 | pub(crate) name: String,
| ^^^^
7 | /// 市区町村名リスト
8 | pub(crate) cities: Vec<String>,
| ^^^^^^
9 | /// 代表点の緯度経度
10 | pub(crate) coordinate: Coordinate,
| ^^^^^^^^^^
|
= note: `PrefectureMaster` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
</code></pre>
__END__
|
Code review with clippy:
core/src/domain/chimei_ruiju/entity.rs#L14
[clippy] reported by reviewdog 🐶
<pre><code>warning: fields `name`, `towns`, and `coordinate` are never read
--> core/src/domain/chimei_ruiju/entity.rs:16:16
|
14 | pub struct CityMaster {
| ---------- fields in this struct
15 | /// 市区町村名
16 | pub(crate) name: String,
| ^^^^
17 | /// 町名リスト
18 | pub(crate) towns: Vec<String>,
| ^^^^^
19 | /// 緯度経度
20 | coordinate: Coordinate,
| ^^^^^^^^^^
|
= note: `CityMaster` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
</code></pre>
Raw Output:
core/src/domain/chimei_ruiju/entity.rs:14:12:w:
<pre><code>warning: fields `name`, `towns`, and `coordinate` are never read
--> core/src/domain/chimei_ruiju/entity.rs:16:16
|
14 | pub struct CityMaster {
| ---------- fields in this struct
15 | /// 市区町村名
16 | pub(crate) name: String,
| ^^^^
17 | /// 町名リスト
18 | pub(crate) towns: Vec<String>,
| ^^^^^
19 | /// 緯度経度
20 | coordinate: Coordinate,
| ^^^^^^^^^^
|
= note: `CityMaster` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
</code></pre>
__END__
|
Code review with clippy:
core/src/domain/chimei_ruiju/entity.rs#L24
[clippy] reported by reviewdog 🐶
<pre><code>warning: fields `name`, `blocks`, and `coordinate` are never read
--> core/src/domain/chimei_ruiju/entity.rs:26:16
|
24 | pub struct TownMaster {
| ---------- fields in this struct
25 | /// 町名
26 | pub(crate) name: String,
| ^^^^
27 | /// 街区リスト
28 | blocks: Vec<Block>,
| ^^^^^^
29 | /// 緯度経度
30 | coordinate: Coordinate,
| ^^^^^^^^^^
|
= note: `TownMaster` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
</code></pre>
Raw Output:
core/src/domain/chimei_ruiju/entity.rs:24:12:w:
<pre><code>warning: fields `name`, `blocks`, and `coordinate` are never read
--> core/src/domain/chimei_ruiju/entity.rs:26:16
|
24 | pub struct TownMaster {
| ---------- fields in this struct
25 | /// 町名
26 | pub(crate) name: String,
| ^^^^
27 | /// 街区リスト
28 | blocks: Vec<Block>,
| ^^^^^^
29 | /// 緯度経度
30 | coordinate: Coordinate,
| ^^^^^^^^^^
|
= note: `TownMaster` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
</code></pre>
__END__
|
Code review with clippy:
core/src/domain/chimei_ruiju/entity.rs#L34
[clippy] reported by reviewdog 🐶
<pre><code>warning: fields `koaza`, `block_number`, `residential_address_indication`, and `coordinate` are never read
--> core/src/domain/chimei_ruiju/entity.rs:36:5
|
34 | pub struct Block {
| ----- fields in this struct
35 | /// 小字・通称名
36 | koaza: String,
| ^^^^^
37 | /// 街区符号・地番
38 | block_number: String,
| ^^^^^^^^^^^^
39 | /// 住居表示の有無
40 | residential_address_indication: bool,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
41 | /// 緯度経度
42 | coordinate: Coordinate,
| ^^^^^^^^^^
|
= note: `Block` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
</code></pre>
Raw Output:
core/src/domain/chimei_ruiju/entity.rs:34:12:w:
<pre><code>warning: fields `koaza`, `block_number`, `residential_address_indication`, and `coordinate` are never read
--> core/src/domain/chimei_ruiju/entity.rs:36:5
|
34 | pub struct Block {
| ----- fields in this struct
35 | /// 小字・通称名
36 | koaza: String,
| ^^^^^
37 | /// 街区符号・地番
38 | block_number: String,
| ^^^^^^^^^^^^
39 | /// 住居表示の有無
40 | residential_address_indication: bool,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
41 | /// 緯度経度
42 | coordinate: Coordinate,
| ^^^^^^^^^^
|
= note: `Block` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
</code></pre>
__END__
|
Code review with clippy:
core/src/domain/chimei_ruiju/entity.rs#L46
[clippy] reported by reviewdog 🐶
<pre><code>warning: fields `latitude` and `longitude` are never read
--> core/src/domain/chimei_ruiju/entity.rs:48:16
|
46 | pub struct Coordinate {
| ---------- fields in this struct
47 | /// 緯度
48 | pub(crate) latitude: f64,
| ^^^^^^^^
49 | /// 経度
50 | pub(crate) longitude: f64,
| ^^^^^^^^^
|
= note: `Coordinate` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
</code></pre>
Raw Output:
core/src/domain/chimei_ruiju/entity.rs:46:12:w:
<pre><code>warning: fields `latitude` and `longitude` are never read
--> core/src/domain/chimei_ruiju/entity.rs:48:16
|
46 | pub struct Coordinate {
| ---------- fields in this struct
47 | /// 緯度
48 | pub(crate) latitude: f64,
| ^^^^^^^^
49 | /// 経度
50 | pub(crate) longitude: f64,
| ^^^^^^^^^
|
= note: `Coordinate` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
</code></pre>
__END__
|
Code review with clippy:
core/src/domain/chimei_ruiju/error.rs#L4
[clippy] reported by reviewdog 🐶
<pre><code>warning: variants `Network`, `NotFound`, and `Deserialize` are never constructed
--> core/src/domain/chimei_ruiju/error.rs:6:5
|
4 | pub enum ApiError {
| -------- variants in this enum
5 | #[error("network error occurs: {url}")]
6 | Network { url: String },
| ^^^^^^^
7 | #[error("resource not found: {url}")]
8 | NotFound { url: String },
| ^^^^^^^^
9 | #[error("deserialize error occurs: {url}")]
10 | Deserialize { url: String },
| ^^^^^^^^^^^
|
= note: `ApiError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
</code></pre>
Raw Output:
core/src/domain/chimei_ruiju/error.rs:4:10:w:
<pre><code>warning: variants `Network`, `NotFound`, and `Deserialize` are never constructed
--> core/src/domain/chimei_ruiju/error.rs:6:5
|
4 | pub enum ApiError {
| -------- variants in this enum
5 | #[error("network error occurs: {url}")]
6 | Network { url: String },
| ^^^^^^^
7 | #[error("resource not found: {url}")]
8 | NotFound { url: String },
| ^^^^^^^^
9 | #[error("deserialize error occurs: {url}")]
10 | Deserialize { url: String },
| ^^^^^^^^^^^
|
= note: `ApiError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
</code></pre>
__END__
|
Code review with clippy:
core/src/repository/chimei_ruiju/city.rs#L6
[clippy] reported by reviewdog 🐶
<pre><code>warning: struct `CityMasterRepository` is never constructed
--> core/src/repository/chimei_ruiju/city.rs:6:12
|
6 | pub struct CityMasterRepository {}
| ^^^^^^^^^^^^^^^^^^^^
</code></pre>
Raw Output:
core/src/repository/chimei_ruiju/city.rs:6:12:w:
<pre><code>warning: struct `CityMasterRepository` is never constructed
--> core/src/repository/chimei_ruiju/city.rs:6:12
|
6 | pub struct CityMasterRepository {}
| ^^^^^^^^^^^^^^^^^^^^
</code></pre>
__END__
|
Code review with clippy:
core/src/repository/chimei_ruiju/city.rs#L8
[clippy] reported by reviewdog 🐶
<pre><code>warning: associated function `get` is never used
--> core/src/repository/chimei_ruiju/city.rs:9:18
|
8 | impl CityMasterRepository {
| ------------------------- associated function in this implementation
9 | pub async fn get(
| ^^^
</code></pre>
Raw Output:
core/src/repository/chimei_ruiju/city.rs:8:1:w:
<pre><code>warning: associated function `get` is never used
--> core/src/repository/chimei_ruiju/city.rs:9:18
|
8 | impl CityMasterRepository {
| ------------------------- associated function in this implementation
9 | pub async fn get(
| ^^^
</code></pre>
__END__
|
Code review with clippy:
core/src/repository/chimei_ruiju/city.rs#L53
[clippy] reported by reviewdog 🐶
<pre><code>warning: associated function `get_blocking` is never used
--> core/src/repository/chimei_ruiju/city.rs:54:12
|
53 | impl CityMasterRepository {
| ------------------------- associated function in this implementation
54 | pub fn get_blocking(
| ^^^^^^^^^^^^
</code></pre>
Raw Output:
core/src/repository/chimei_ruiju/city.rs:53:1:w:
<pre><code>warning: associated function `get_blocking` is never used
--> core/src/repository/chimei_ruiju/city.rs:54:12
|
53 | impl CityMasterRepository {
| ------------------------- associated function in this implementation
54 | pub fn get_blocking(
| ^^^^^^^^^^^^
</code></pre>
__END__
|
Code review with clippy:
core/src/repository/chimei_ruiju/prefecture.rs#L6
[clippy] reported by reviewdog 🐶
<pre><code>warning: struct `PrefectureMasterRepository` is never constructed
--> core/src/repository/chimei_ruiju/prefecture.rs:6:12
|
6 | pub struct PrefectureMasterRepository {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
</code></pre>
Raw Output:
core/src/repository/chimei_ruiju/prefecture.rs:6:12:w:
<pre><code>warning: struct `PrefectureMasterRepository` is never constructed
--> core/src/repository/chimei_ruiju/prefecture.rs:6:12
|
6 | pub struct PrefectureMasterRepository {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
</code></pre>
__END__
|
Loading