正式ではない住所表記への対応にmainブランチを取り込み #117
Annotations
1 error and 7 warnings
Code formatting
Process completed with exit code 128.
|
Code review with clippy:
src/api/mock.rs#L41
[clippy] reported by reviewdog 🐶
<pre><code>warning: float has excessive precision
--> src/api/mock.rs:41:35
|
41 | lng: Some(139.331577),
| ^^^^^^^^^^ help: consider changing the type or truncating it to: `139.331_57`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
= note: `#[warn(clippy::excessive_precision)]` on by default
</code></pre>
Raw Output:
src/api/mock.rs:41:35:w:
<pre><code>warning: float has excessive precision
--> src/api/mock.rs:41:35
|
41 | lng: Some(139.331577),
| ^^^^^^^^^^ help: consider changing the type or truncating it to: `139.331_57`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
= note: `#[warn(clippy::excessive_precision)]` on by default
</code></pre>
__END__
|
Code review with clippy:
src/api/mock.rs#L47
[clippy] reported by reviewdog 🐶
<pre><code>warning: float has excessive precision
--> src/api/mock.rs:47:35
|
47 | lng: Some(139.329437),
| ^^^^^^^^^^ help: consider changing the type or truncating it to: `139.329_44`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
</code></pre>
Raw Output:
src/api/mock.rs:47:35:w:
<pre><code>warning: float has excessive precision
--> src/api/mock.rs:47:35
|
47 | lng: Some(139.329437),
| ^^^^^^^^^^ help: consider changing the type or truncating it to: `139.329_44`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
</code></pre>
__END__
|
Code review with clippy:
src/api/mock.rs#L53
[clippy] reported by reviewdog 🐶
<pre><code>warning: float has excessive precision
--> src/api/mock.rs:53:35
|
53 | lng: Some(139.328261),
| ^^^^^^^^^^ help: consider changing the type or truncating it to: `139.328_26`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
</code></pre>
Raw Output:
src/api/mock.rs:53:35:w:
<pre><code>warning: float has excessive precision
--> src/api/mock.rs:53:35
|
53 | lng: Some(139.328261),
| ^^^^^^^^^^ help: consider changing the type or truncating it to: `139.328_26`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
</code></pre>
__END__
|
Code review with clippy:
src/api/mock.rs#L59
[clippy] reported by reviewdog 🐶
<pre><code>warning: float has excessive precision
--> src/api/mock.rs:59:35
|
59 | lng: Some(139.323896),
| ^^^^^^^^^^ help: consider changing the type or truncating it to: `139.323_9`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
</code></pre>
Raw Output:
src/api/mock.rs:59:35:w:
<pre><code>warning: float has excessive precision
--> src/api/mock.rs:59:35
|
59 | lng: Some(139.323896),
| ^^^^^^^^^^ help: consider changing the type or truncating it to: `139.323_9`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
</code></pre>
__END__
|
Code review with clippy:
src/api/mock.rs#L71
[clippy] reported by reviewdog 🐶
<pre><code>warning: float has excessive precision
--> src/api/mock.rs:71:35
|
71 | lng: Some(139.326709),
| ^^^^^^^^^^ help: consider changing the type or truncating it to: `139.326_7`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
</code></pre>
Raw Output:
src/api/mock.rs:71:35:w:
<pre><code>warning: float has excessive precision
--> src/api/mock.rs:71:35
|
71 | lng: Some(139.326709),
| ^^^^^^^^^^ help: consider changing the type or truncating it to: `139.326_7`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision
</code></pre>
__END__
|
Code review with clippy:
src/api.rs#L10
[clippy] reported by reviewdog 🐶
<pre><code>warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified
--> src/api.rs:10:5
|
10 | async fn get_prefecture_master(&self, prefecture_name: &str) -> Result<Prefecture, Error>;
| ^^^^^
|
= note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future`
= note: `#[warn(async_fn_in_trait)]` on by default
help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change
|
10 - async fn get_prefecture_master(&self, prefecture_name: &str) -> Result<Prefecture, Error>;
10 + fn get_prefecture_master(&self, prefecture_name: &str) -> impl std::future::Future<Output = Result<Prefecture, Error>> + Send;
|
</code></pre>
Raw Output:
src/api.rs:10:5:w:
<pre><code>warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified
--> src/api.rs:10:5
|
10 | async fn get_prefecture_master(&self, prefecture_name: &str) -> Result<Prefecture, Error>;
| ^^^^^
|
= note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future`
= note: `#[warn(async_fn_in_trait)]` on by default
help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change
|
10 - async fn get_prefecture_master(&self, prefecture_name: &str) -> Result<Prefecture, Error>;
10 + fn get_prefecture_master(&self, prefecture_name: &str) -> impl std::future::Future<Output = Result<Prefecture, Error>> + Send;
|
</code></pre>
__END__
|
Code review with clippy:
src/api.rs#L11
[clippy] reported by reviewdog 🐶
<pre><code>warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified
--> src/api.rs:11:5
|
11 | async fn get_city_master(&self, prefecture_name: &str, city_name: &str) -> Result<City, Error>;
| ^^^^^
|
= note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future`
help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change
|
11 - async fn get_city_master(&self, prefecture_name: &str, city_name: &str) -> Result<City, Error>;
11 + fn get_city_master(&self, prefecture_name: &str, city_name: &str) -> impl std::future::Future<Output = Result<City, Error>> + Send;
|
</code></pre>
Raw Output:
src/api.rs:11:5:w:
<pre><code>warning: use of `async fn` in public traits is discouraged as auto trait bounds cannot be specified
--> src/api.rs:11:5
|
11 | async fn get_city_master(&self, prefecture_name: &str, city_name: &str) -> Result<City, Error>;
| ^^^^^
|
= note: you can suppress this lint if you plan to use the trait only in your own code, or do not care about auto traits like `Send` on the `Future`
help: you can alternatively desugar to a normal `fn` that returns `impl Future` and add any desired bounds such as `Send`, but these cannot be relaxed without a breaking API change
|
11 - async fn get_city_master(&self, prefecture_name: &str, city_name: &str) -> Result<City, Error>;
11 + fn get_city_master(&self, prefecture_name: &str, city_name: &str) -> impl std::future::Future<Output = Result<City, Error>> + Send;
|
</code></pre>
__END__
|
The logs for this run have expired and are no longer available.
Loading