Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

表記ゆれアダプタのリファクタ #396

Closed
YuukiToriyama opened this issue Sep 1, 2024 · 1 comment · Fixed by #436
Closed

表記ゆれアダプタのリファクタ #396

YuukiToriyama opened this issue Sep 1, 2024 · 1 comment · Fixed by #436
Assignees
@YuukiToriyama
Labels
Core コアモジュール関連の修正
Milestone
表記ゆれアダプタのリファクタ

Comments

@YuukiToriyama
Copy link
Owner

概要

  • OrthographicalVariantAdapterはメソッドapplyに処理がつまりすぎているため、可読性が低い、テストしにくいなどの問題を抱えている。
  • 必要な表記ゆれパターンの選別、揺れパターンを適用したマッチ候補の生成、マッチ候補と入力値の検証、くらいで細かく関数を分けられないか

その他
@YuukiToriyama YuukiToriyama self-assigned this Sep 1, 2024
YuukiToriyama added a commit that referenced this issue Sep 1, 2024
@YuukiToriyama
add: #396: coreクレートにcriterionを追加
ba09250 
ベンチマークテストを行なうため
YuukiToriyama added a commit that referenced this issue Sep 1, 2024
@YuukiToriyama
update: #396: japanese_address_parser::parser::adapterの可視性を変更
89c1adb 
ベンチマークテストから見えるようにするため
YuukiToriyama added a commit that referenced this issue Sep 1, 2024
@YuukiToriyama
add: #396: ベンチマークテストにOrthographicalVariantAdapterに対するテストを追加
ffb749d
YuukiToriyama added a commit that referenced this issue Sep 1, 2024
@YuukiToriyama
fix: #396: criterionのdefault-featuresを無効にした
9ef65fb 
`wasm-pack test`が失敗するため

see also: https://github.com/bheisler/criterion.rs/blob/5d169ae1ec2604cb1f2e89551bf44a0cfaa28a76/src/lib.rs#L27
@YuukiToriyama YuukiToriyama mentioned this issue Sep 1, 2024
Merged
YuukiToriyama added a commit that referenced this issue Sep 1, 2024
@YuukiToriyama
update: #396: code-quality-check.yamlにベンチマークを実行するステップを追加
c309ecc
@YuukiToriyama YuukiToriyama mentioned this issue Sep 1, 2024
Merged
YuukiToriyama added a commit that referenced this issue Sep 1, 2024
@YuukiToriyama
update: #396: ベンチマークテストを実行するディレクトリ(クレート)を設定
ab4cc16
YuukiToriyama added a commit that referenced this issue Sep 1, 2024
@YuukiToriyama
fix: #396: cargo bench実行時にエラーが出るためworkaroundとしてlib.bench = falseを設定
8c6d327 
see also: https://bheisler.github.io/criterion.rs/book/faq.html#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options
YuukiToriyama added a commit that referenced this issue Sep 1, 2024
@YuukiToriyama
fix: #396: ベンチマークの名前を指定
e76721b
YuukiToriyama added a commit that referenced this issue Sep 1, 2024
@YuukiToriyama
update: #396: code-quality-check.yamlの実行条件を調整
c879641 
拡張子が`.rs`であるファイル、または`Cargo.toml`が変更されたときにのみ実行されるようにした
YuukiToriyama added a commit that referenced this issue Sep 1, 2024
@YuukiToriyama
update: #396: Vec<Variant>の中から必要なもののみを取り出す処理をfilterを使って書き直した
da5a42d
YuukiToriyama added a commit that referenced this issue Sep 1, 2024
@YuukiToriyama
update: #396: 不要なcloneを削除
02a6b8a
YuukiToriyama added a commit that referenced this issue Sep 1, 2024
@YuukiToriyama
update: #396: if文をfilterに置き換えた
cf057a6
@YuukiToriyama YuukiToriyama mentioned this issue Sep 1, 2024
Merged
@YuukiToriyama YuukiToriyama added the Core コアモジュール関連の修正 label Sep 1, 2024
@YuukiToriyama YuukiToriyama mentioned this issue Sep 5, 2024
Merged
@YuukiToriyama
Copy link
Owner Author

表記ゆれアダプタを別のクレートに切り出したらどうか？

This was referenced Sep 27, 2024
Merged
Merged
@YuukiToriyama YuukiToriyama linked a pull request Sep 27, 2024 that will close this issue
release/v0.1.17をmainブランチにマージ #436
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YuukiToriyama YuukiToriyama

Labels
Core コアモジュール関連の修正
Projects
None yet
Milestone
表記ゆれアダプタのリファクタ
Development

Successfully merging a pull request may close this issue.

release/v0.1.17をmainブランチにマージ YuukiToriyama/japanese-address-parser
1 participant
@YuukiToriyama