Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

文字列に半角スペースなどが含まれていると処理に失敗する #410

Closed
YuukiToriyama opened this issue Sep 12, 2024 · 3 comments
Closed

文字列に半角スペースなどが含まれていると処理に失敗する #410

YuukiToriyama opened this issue Sep 12, 2024 · 3 comments
Assignees
@YuukiToriyama
Milestone
不要な空白の除去

Comments

@YuukiToriyama
Copy link
Owner

概要

  • 「東京都中野区中野 4-11-19」のように半角スペースが入っていると「中野四丁目」と認識できない
@YuukiToriyama YuukiToriyama self-assigned this Sep 12, 2024
@YuukiToriyama
Copy link
Owner Author

半角スペースを取り除く処理をライブラリ側で行なうのかライブラリを使用する側に任せるのか

@YuukiToriyama
Copy link
Owner Author

feature flagで有効にしたときのみ半角スペースの除去を有効にする

YuukiToriyama added a commit that referenced this issue Sep 12, 2024
@YuukiToriyama
update: #410: 文字列からホワイトスペースを取り除くメソッドを定義
9ff4e88
YuukiToriyama added a commit that referenced this issue Sep 12, 2024
@YuukiToriyama
update: #410: フィーチャフラグeliminate-whitespacesが指定された場合、入力された文字列からホワイトス…
8aaebcd 
…ペースを取り除くようにした
YuukiToriyama added a commit that referenced this issue Sep 12, 2024
@YuukiToriyama
update: #410: フィーチャフラグeliminate-whitespacesについてドキュメントに記載
f61e93d
@YuukiToriyama YuukiToriyama mentioned this issue Sep 12, 2024
Merged
YuukiToriyama added a commit that referenced this issue Sep 12, 2024
@YuukiToriyama
update: #410: wasmクレートのnightlyフィーチャに`japanese-address-parser/eliminat…
a9e2748 
…e-whitespaces`を追加

nightlyビルドではホワイトスペースの除却を有効化する
@YuukiToriyama YuukiToriyama mentioned this issue Sep 12, 2024
Merged
@YuukiToriyama
Copy link
Owner Author

YuukiToriyama commented Sep 12, 2024 •
edited
Loading

何をホワイトスペースとするかはRustのchar#is_whitespaceの実装に従うことにする

https://doc.rust-lang.org/std/primitive.char.html#method.is_whitespace

This was referenced Sep 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YuukiToriyama YuukiToriyama

Labels
None yet
Projects
None yet
Milestone
不要な空白の除去
Development

When branches are created from issues, their pull requests are automatically linked.

feature/strip-whitespaces/master YuukiToriyama/japanese-address-parser
1 participant
@YuukiToriyama