-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API失敗時のテストコードをrelease/v0.1.0-beta.3にマージ #124
Merged
YuukiToriyama
merged 27 commits into
release/v0.1.0-beta.3
from
feature/unit-test-on-api-failed/master
Jan 12, 2024
Merged
API失敗時のテストコードをrelease/v0.1.0-beta.3にマージ #124
YuukiToriyama
merged 27 commits into
release/v0.1.0-beta.3
from
feature/unit-test-on-api-failed/master
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
都道府県マスタを取得するためのモジュール
市区町村マスタを取得するためのモジュール
`client.rs`, `blocking.rs`にそれぞれ書いていたものを移植している
`client.rs`, `blocking.rs`にそれぞれ書いていたものを移植している
…asterApiを持つような実装に変更 ライフタイムの関係でコンパイルができないため
…piとCityMasterApiを持つような実装に変更 ライフタイムの関係でコンパイルができないため
…ailed/re-organization-api-module API失敗時のテストコード: `api`モジュールの再編
…ailed/add-test API失敗時のテストコード: 都道府県マスタ/市区町村マスタが取得できない場合のテストコードを追加
…ailed/update-readme API失敗時のテストコード: READMEのサンプルコードを修正
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: you should consider adding a `Default` implementation for `Parser`
--> src/lib.rs:18:5
|
18 | / pub fn new() -> Self {
19 | | Parser {}
20 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
= note: `#[warn(clippy::new_without_default)]` on by default
help: try adding this
|
16 + impl Default for Parser {
17 + fn default() -> Self {
18 + Self::new()
19 + }
20 + }
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更点
api
モジュールの再編 #119備考