Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS側のRegExpを使用する: リファクタリング #134

Merged
merged 8 commits into from
Jan 20, 2024
Merged

JS側のRegExpを使用する: リファクタリング #134

merged 8 commits into from
Jan 20, 2024

Commits on Jan 20, 2024

  1. update: JS側のRegExpを使用する: extract_town_name_with_js_sys_regexp()がNon… 

    …eを返す場合のテストを追加

リファクタリングのデグレ確認に使用するため
    @YuukiToriyama
    YuukiToriyama committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    8d4c69a View commit details
    Browse the repository at this point in the history

  2. update: JS側のRegExpを使用する: unwrap()をok()?に書き換えた

    @YuukiToriyama
    YuukiToriyama committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    fed4226 View commit details
    Browse the repository at this point in the history

  3. update: JS側のRegExpを使用する: match式を?で書き換えた

    @YuukiToriyama
    YuukiToriyama committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    f2cd308 View commit details
    Browse the repository at this point in the history

  4. update: JS側のRegExpを使用する: 正規表現を簡略化 

    名前付きキャプチャグループは使用しないので削除
    @YuukiToriyama
    YuukiToriyama committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    aaf362f View commit details
    Browse the repository at this point in the history

  5. update: JS側のRegExpを使用する: filter_with_js_sys_regexp()に対するテスト関数の命名を修正 

    success/failではなくより実情にそぐうものに変更
    @YuukiToriyama
    YuukiToriyama committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    ec3cd3b View commit details
    Browse the repository at this point in the history

  6. update: JS側のRegExpを使用する: filter_with_js_sys_regexp()に対するテストにケースを追加

    @YuukiToriyama
    YuukiToriyama committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    60e1534 View commit details
    Browse the repository at this point in the history

  7. update: JS側のRegExpを使用する: to_japanese_form()の呼び出し箇所にエラーハンドリングを追加

    @YuukiToriyama
    YuukiToriyama committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    7fbb8f2 View commit details
    Browse the repository at this point in the history

  8. update: JS側のRegExpを使用する: 正規表現を簡略化 

    名前付きキャプチャグループは使用しないので削除
    @YuukiToriyama
    YuukiToriyama committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    0d24d81 View commit details
    Browse the repository at this point in the history