表記ゆれアダプタのリファクタ: OrthographicVariantAdapterに対するベンチマークテストを作成
#397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wasm-pack test`が失敗するため see also: https://github.com/bheisler/criterion.rs/blob/5d169ae1ec2604cb1f2e89551bf44a0cfaa28a76/src/lib.rs#L27
YuukiToriyama
merged commit c19678d
into
feature/refactor-orthographical-variant-adapter/master
7 checks passed
YuukiToriyama
deleted the
feature/refactor-orthographical-variant-adapter/add-benchmark
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更点
coreに対してcriterionを導入し、ベンチマークテストを実行できるようにした。OrthographicVariantAdapterに対していくつかのケースを追加した。備考
parser::adapterが見えなかったため、仕方なくpublicにしている。