From c309ecc2147dc3b64614f45451ad9b88c603ebf0 Mon Sep 17 00:00:00 2001 From: Yuuki Toriyama Date: Sun, 1 Sep 2024 20:53:24 +0900 Subject: [PATCH 1/5] =?UTF-8?q?update:=20#396:=20`code-quality-check.yaml`?= =?UTF-8?q?=E3=81=AB=E3=83=99=E3=83=B3=E3=83=81=E3=83=9E=E3=83=BC=E3=82=AF?= =?UTF-8?q?=E3=82=92=E5=AE=9F=E8=A1=8C=E3=81=99=E3=82=8B=E3=82=B9=E3=83=86?= =?UTF-8?q?=E3=83=83=E3=83=97=E3=82=92=E8=BF=BD=E5=8A=A0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/code-quality-check.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/code-quality-check.yaml b/.github/workflows/code-quality-check.yaml index 936a7f5f..692c2bcf 100644 --- a/.github/workflows/code-quality-check.yaml +++ b/.github/workflows/code-quality-check.yaml @@ -21,3 +21,8 @@ jobs: reporter: 'github-pr-review' filter_mode: 'nofilter' github_token: ${{ secrets.GITHUB_TOKEN }} + - name: Run benchmark + uses: boa-dev/criterion-compare-action@v3 + with: + token: ${{ secrets.GITHUB_TOKEN }} + branchName: ${{ github.base_ref }} From ab4cc16610734b06d3881557738bda6ed8495cc5 Mon Sep 17 00:00:00 2001 From: Yuuki Toriyama Date: Sun, 1 Sep 2024 21:07:32 +0900 Subject: [PATCH 2/5] =?UTF-8?q?update:=20#396:=20=E3=83=99=E3=83=B3?= =?UTF-8?q?=E3=83=81=E3=83=9E=E3=83=BC=E3=82=AF=E3=83=86=E3=82=B9=E3=83=88?= =?UTF-8?q?=E3=82=92=E5=AE=9F=E8=A1=8C=E3=81=99=E3=82=8B=E3=83=87=E3=82=A3?= =?UTF-8?q?=E3=83=AC=E3=82=AF=E3=83=88=E3=83=AA(=E3=82=AF=E3=83=AC?= =?UTF-8?q?=E3=83=BC=E3=83=88)=E3=82=92=E8=A8=AD=E5=AE=9A?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/code-quality-check.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/code-quality-check.yaml b/.github/workflows/code-quality-check.yaml index 692c2bcf..3b7554ef 100644 --- a/.github/workflows/code-quality-check.yaml +++ b/.github/workflows/code-quality-check.yaml @@ -26,3 +26,4 @@ jobs: with: token: ${{ secrets.GITHUB_TOKEN }} branchName: ${{ github.base_ref }} + cwd: 'core' From 8c6d32745954de1429ea3a4978af307535b3b1aa Mon Sep 17 00:00:00 2001 From: Yuuki Toriyama Date: Sun, 1 Sep 2024 21:18:39 +0900 Subject: [PATCH 3/5] =?UTF-8?q?fix:=20#396:=20`cargo=20bench`=E5=AE=9F?= =?UTF-8?q?=E8=A1=8C=E6=99=82=E3=81=AB=E3=82=A8=E3=83=A9=E3=83=BC=E3=81=8C?= =?UTF-8?q?=E5=87=BA=E3=82=8B=E3=81=9F=E3=82=81workaround=E3=81=A8?= =?UTF-8?q?=E3=81=97=E3=81=A6`lib.bench=20=3D=20false`=E3=82=92=E8=A8=AD?= =?UTF-8?q?=E5=AE=9A?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit see also: https://bheisler.github.io/criterion.rs/book/faq.html#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options --- core/Cargo.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/core/Cargo.toml b/core/Cargo.toml index 8a9a88ab..aaddccd1 100644 --- a/core/Cargo.toml +++ b/core/Cargo.toml @@ -13,6 +13,7 @@ rust-version = "1.73.0" [lib] crate-type = ["rlib", "cdylib"] +bench = false [features] default = ["city-name-correction"] From e76721bdcc8177692ba9dd502073452309435ce8 Mon Sep 17 00:00:00 2001 From: Yuuki Toriyama Date: Sun, 1 Sep 2024 21:30:50 +0900 Subject: [PATCH 4/5] =?UTF-8?q?fix:=20#396:=20=E3=83=99=E3=83=B3=E3=83=81?= =?UTF-8?q?=E3=83=9E=E3=83=BC=E3=82=AF=E3=81=AE=E5=90=8D=E5=89=8D=E3=82=92?= =?UTF-8?q?=E6=8C=87=E5=AE=9A?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/code-quality-check.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/code-quality-check.yaml b/.github/workflows/code-quality-check.yaml index 3b7554ef..97b99b95 100644 --- a/.github/workflows/code-quality-check.yaml +++ b/.github/workflows/code-quality-check.yaml @@ -27,3 +27,4 @@ jobs: token: ${{ secrets.GITHUB_TOKEN }} branchName: ${{ github.base_ref }} cwd: 'core' + benchName: 'core_benchmark' From c879641a859f00edc110eef11f99f66344e33d9d Mon Sep 17 00:00:00 2001 From: Yuuki Toriyama Date: Sun, 1 Sep 2024 21:37:28 +0900 Subject: [PATCH 5/5] =?UTF-8?q?update:=20#396:=20`code-quality-check.yaml`?= =?UTF-8?q?=E3=81=AE=E5=AE=9F=E8=A1=8C=E6=9D=A1=E4=BB=B6=E3=82=92=E8=AA=BF?= =?UTF-8?q?=E6=95=B4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 拡張子が`.rs`であるファイル、または`Cargo.toml`が変更されたときにのみ実行されるようにした --- .github/workflows/code-quality-check.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/code-quality-check.yaml b/.github/workflows/code-quality-check.yaml index 97b99b95..a1be635e 100644 --- a/.github/workflows/code-quality-check.yaml +++ b/.github/workflows/code-quality-check.yaml @@ -2,6 +2,9 @@ name: Code quality check on: pull_request: + paths: + - '**.rs' + - '**/Cargo.toml' jobs: build: