Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

表記ゆれアダプタのリファクタ: PR作成時にベンチマークテストが走るように設定 #398

Merged
merged 5 commits into from
Sep 1, 2024
Merged

表記ゆれアダプタのリファクタ: PR作成時にベンチマークテストが走るように設定 #398

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c309ecc
update: #396: `code-quality-check.yaml`にベンチマークを実行するステップを追加
YuukiToriyama Sep 1, 2024
ab4cc16
update: #396: ベンチマークテストを実行するディレクトリ(クレート)を設定
YuukiToriyama Sep 1, 2024
8c6d327
fix: #396: `cargo bench`実行時にエラーが出るためworkaroundとして`lib.bench = false`を設定
YuukiToriyama Sep 1, 2024
e76721b
fix: #396: ベンチマークの名前を指定
YuukiToriyama Sep 1, 2024
c879641
update: #396: `code-quality-check.yaml`の実行条件を調整
YuukiToriyama Sep 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/code-quality-check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ name: Code quality check

on:
pull_request:
paths:
- '**.rs'
- '**/Cargo.toml'

jobs:
build:
Expand All @@ -21,3 +24,10 @@ jobs:
reporter: 'github-pr-review'
filter_mode: 'nofilter'
github_token: ${{ secrets.GITHUB_TOKEN }}
- name: Run benchmark
uses: boa-dev/criterion-compare-action@v3
with:
token: ${{ secrets.GITHUB_TOKEN }}
branchName: ${{ github.base_ref }}
cwd: 'core'
benchName: 'core_benchmark'
1 change: 1 addition & 0 deletions core/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ rust-version = "1.73.0"

[lib]
crate-type = ["rlib", "cdylib"]
bench = false

[features]
default = ["city-name-correction"]
Expand Down
Loading