Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

異字体セレクタを含む入力への対応: 文字列から異字体セレクタを取り除くメソッドを定義 #401

Conversation

YuukiToriyama
Copy link
Owner

変更点

@@ -0,0 +1,62 @@
pub(crate) trait CharExt {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [clippy] reported by reviewdog 🐶

warning: trait `CharExt` is never used
 --> core/src/util/extension.rs:1:18
  |
1 | pub(crate) trait CharExt {
  |                  ^^^^^^^
  |
  = note: `#[warn(dead_code)]` on by default

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

次のPRで使用箇所が発生する予定

}
}

pub(crate) trait StrExt {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [clippy] reported by reviewdog 🐶

warning: trait `StrExt` is never used
  --> core/src/util/extension.rs:12:18
   |
12 | pub(crate) trait StrExt {
   |                  ^^^^^^

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

次のPRで使用箇所が発生する予定

@YuukiToriyama YuukiToriyama changed the title 異字体セレクタを含む文字列への対応: 文字列から異字体セレクタを取り除くメソッドを定義 異字体セレクタを含む入力への対応: 文字列から異字体セレクタを取り除くメソッドを定義 Sep 3, 2024
@YuukiToriyama YuukiToriyama marked this pull request as ready for review September 3, 2024 14:31
@YuukiToriyama YuukiToriyama merged commit 5c64433 into feature/filter-unicode-variation-selectors/master Sep 3, 2024
7 checks passed
@YuukiToriyama YuukiToriyama deleted the feature/filter-unicode-variation-selectors/add-utility-method branch September 3, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant