chimei-ruiju.orgへの対応: repositoryにchimei-ruiju用の構造体を定義
#428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -13,17 +13,17 @@ pub struct PrefectureMaster { | |||
| #[derive(Deserialize, Debug)] | |||
| pub struct CityMaster { | |||
There was a problem hiding this comment.
warning: fields `name`, `towns`, and `coordinate` are never read
--> core/src/domain/chimei_ruiju/entity.rs:16:16
|
14 | pub struct CityMaster {
| ---------- fields in this struct
15 | /// 市区町村名
16 | pub(crate) name: String,
| ^^^^
17 | /// 町名リスト
18 | pub(crate) towns: Vec,
| ^^^^^
19 | /// 緯度経度
20 | coordinate: Coordinate,
| ^^^^^^^^^^
|
= note: `CityMaster` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
| /// 町名リスト | ||
| towns: Vec<String>, | ||
| pub(crate) towns: Vec<String>, | ||
| /// 緯度経度 | ||
| coordinate: Coordinate, | ||
| } | ||
|
|
||
| #[derive(Deserialize, Debug)] | ||
| pub struct TownMaster { |
There was a problem hiding this comment.
warning: fields `name`, `blocks`, and `coordinate` are never read
--> core/src/domain/chimei_ruiju/entity.rs:26:16
|
24 | pub struct TownMaster {
| ---------- fields in this struct
25 | /// 町名
26 | pub(crate) name: String,
| ^^^^
27 | /// 街区リスト
28 | blocks: Vec,
| ^^^^^^
29 | /// 緯度経度
30 | coordinate: Coordinate,
| ^^^^^^^^^^
|
= note: `TownMaster` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
| use crate::service::chimei_ruiju::ChimeiRuijuApiService; | ||
| use jisx0401::Prefecture; | ||
|
|
||
| pub struct CityMasterRepository { |
There was a problem hiding this comment.
warning: struct `CityMasterRepository` is never constructed
--> core/src/repository/chimei_ruiju/city.rs:6:12
|
6 | pub struct CityMasterRepository {
| ^^^^^^^^^^^^^^^^^^^^
| api_service: ChimeiRuijuApiService, | ||
| } | ||
|
|
||
| impl CityMasterRepository { |
There was a problem hiding this comment.
warning: method `get` is never used
--> core/src/repository/chimei_ruiju/city.rs:11:18
|
10 | impl CityMasterRepository {
| ------------------------- method in this implementation
11 | pub async fn get(
| ^^^
| } | ||
|
|
||
| #[cfg(feature = "blocking")] | ||
| impl CityMasterRepository { |
There was a problem hiding this comment.
warning: method `get_blocking` is never used
--> core/src/repository/chimei_ruiju/city.rs:58:12
|
57 | impl CityMasterRepository {
| ------------------------- method in this implementation
58 | pub fn get_blocking(
| ^^^^^^^^^^^^
| use crate::service::chimei_ruiju::ChimeiRuijuApiService; | ||
| use jisx0401::Prefecture; | ||
|
|
||
| pub struct PrefectureMasterRepository { |
There was a problem hiding this comment.
warning: struct `PrefectureMasterRepository` is never constructed
--> core/src/repository/chimei_ruiju/prefecture.rs:6:12
|
6 | pub struct PrefectureMasterRepository {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
| api_service: ChimeiRuijuApiService, | ||
| } | ||
|
|
||
| impl PrefectureMasterRepository { |
There was a problem hiding this comment.
warning: method `get` is never used
--> core/src/repository/chimei_ruiju/prefecture.rs:11:18
|
10 | impl PrefectureMasterRepository {
| ------------------------------- method in this implementation
11 | pub async fn get(&self, prefecture: &Prefecture) -> Result {
| ^^^
| } | ||
|
|
||
| #[cfg(feature = "blocking")] | ||
| impl PrefectureMasterRepository { |
There was a problem hiding this comment.
warning: method `get_blocking` is never used
--> core/src/repository/chimei_ruiju/prefecture.rs:138:12
|
137 | impl PrefectureMasterRepository {
| ------------------------------- method in this implementation
138 | pub fn get_blocking(&self, prefecture: Prefecture) -> Result {
| ^^^^^^^^^^^^
| api_service: ChimeiRuijuApiService, | ||
| } | ||
|
|
||
| impl TownMasterRepository { |
There was a problem hiding this comment.
warning: method `get` is never used
--> core/src/repository/chimei_ruiju/town.rs:12:18
|
11 | impl TownMasterRepository {
| ------------------------- method in this implementation
12 | pub async fn get(
| ^^^
| } | ||
|
|
||
| #[cfg(feature = "blocking")] | ||
| impl TownMasterRepository { |
There was a problem hiding this comment.
warning: method `get_blocking` is never used
--> core/src/repository/chimei_ruiju/town.rs:50:12
|
49 | impl TownMasterRepository {
| ------------------------- method in this implementation
50 | pub fn get_blocking(
| ^^^^^^^^^^^^
There was a problem hiding this comment.
warning: fields `name`, `cities`, and `coordinate` are never read
--> core/src/domain/chimei_ruiju/entity.rs:6:16
|
4 | pub struct PrefectureMaster {
| ---------------- fields in this struct
5 | /// 都道府県名
6 | pub(crate) name: String,
| ^^^^
7 | /// 市区町村名リスト
8 | pub(crate) cities: Vec,
| ^^^^^^
9 | /// 代表点の緯度経度
10 | pub(crate) coordinate: Coordinate,
| ^^^^^^^^^^
|
= note: `PrefectureMaster` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
There was a problem hiding this comment.
warning: fields `koaza`, `block_number`, `residential_address_indication`, and `coordinate` are never read
--> core/src/domain/chimei_ruiju/entity.rs:36:5
|
34 | pub struct Block {
| ----- fields in this struct
35 | /// 小字・通称名
36 | koaza: String,
| ^^^^^
37 | /// 街区符号・地番
38 | block_number: String,
| ^^^^^^^^^^^^
39 | /// 住居表示の有無
40 | residential_address_indication: bool,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
41 | /// 緯度経度
42 | coordinate: Coordinate,
| ^^^^^^^^^^
|
= note: `Block` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
There was a problem hiding this comment.
warning: fields `latitude` and `longitude` are never read
--> core/src/domain/chimei_ruiju/entity.rs:48:16
|
46 | pub struct Coordinate {
| ---------- fields in this struct
47 | /// 緯度
48 | pub(crate) latitude: f64,
| ^^^^^^^^
49 | /// 経度
50 | pub(crate) longitude: f64,
| ^^^^^^^^^
|
= note: `Coordinate` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
変更点
repositoryに追加しました。