Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParsedAddressの修正をrelease/v0.1.21にマージ #484

Merged
merged 8 commits into from
Oct 29, 2024

Conversation

YuukiToriyama
Copy link
Owner

@YuukiToriyama YuukiToriyama commented Oct 28, 2024

変更点

  • Parserの再設計 #470experimentalモジュールに追加したParsedAddressの各フィールドがprivateになっており、外部クレートから参照できない状態になっていたので、publicに変更します
  • また、Parserの再設計 #470 で追加したコードとその関連箇所にtypoがあったため修正します

外部クレートから`Metadata`のフィールドが参照できなくなっていたため
外部クレートから`ParsedAddress`のフィールドが参照できなくなっていたため
…/change-visibilities-of-fields

ParsedAddressの修正: フィールドの可視性をprivateからpublicに変更
…/fix-docs-for-new-parser

ParsedAddressの修正: `Parser#parse`のドキュメントの修正
@YuukiToriyama YuukiToriyama added this to the ParsedAddressの修正 milestone Oct 28, 2024
@YuukiToriyama YuukiToriyama self-assigned this Oct 28, 2024
Copy link
Contributor

Benchmark for 28966d7

Click to view benchmark
Test Base PR %
orthographical_variant_adapter/松ケ崎東池ノ内町/松が崎東池ノ内町 435.4±25.21ns 440.8±4.04ns +1.24%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ガ﨑東池の内町 2.3±0.02µs 2.3±0.03µs 0.00%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ケ﨑東池の内町 2.4±0.06µs 2.4±0.03µs 0.00%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ケ﨑東池ノ内町 1513.2±42.66ns 1529.0±49.13ns +1.04%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ヶ崎東池ノ内町 288.4±6.99ns 294.5±2.42ns +2.12%

`軽度` -> `経度`
…/fix-typo

ParsedAddressの修正: Typoを修正
Copy link
Contributor

Benchmark for 777ccc9

Click to view benchmark
Test Base PR %
orthographical_variant_adapter/松ケ崎東池ノ内町/松が崎東池ノ内町 428.5±5.70ns 444.0±24.05ns +3.62%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ガ﨑東池の内町 2.3±0.03µs 2.3±0.04µs 0.00%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ケ﨑東池の内町 2.3±0.03µs 2.4±0.03µs +4.35%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ケ﨑東池ノ内町 1523.5±26.74ns 1525.0±43.28ns +0.10%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ヶ崎東池ノ内町 286.8±2.44ns 295.1±6.59ns +2.89%

@YuukiToriyama YuukiToriyama marked this pull request as ready for review October 29, 2024 22:14
@YuukiToriyama YuukiToriyama merged commit 79b5249 into release/v0.1.21 Oct 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant