Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chimei-ruiju.org: Clippyの警告を抑制 #491

Conversation

YuukiToriyama
Copy link
Owner

変更点

  • chimei-ruiju.orgへの対応 #426
  • clippyの警告を抑制するために、現在使用箇所がないが今後使用予定のものに#[allow(dead_code)]を付与します。
  • また、experimentalモジュールで使用されているものについては、フィーチャフラグexperimentalが有効な場合のみビルドされるように設定します。

clippyの警告を抑制したいため。現時点では使用されていないが将来的には使用される予定。
…れるように設定

現時点では`experimental::Parser`以外からは使用されていないため
@YuukiToriyama YuukiToriyama self-assigned this Oct 31, 2024
Copy link
Contributor

Benchmark for 0fe86c0

Click to view benchmark
Test Base PR %
orthographical_variant_adapter/松ケ崎東池ノ内町/松が崎東池ノ内町 433.7±10.59ns 441.5±22.89ns +1.80%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ガ﨑東池の内町 2.3±0.02µs 2.2±0.06µs -4.35%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ケ﨑東池の内町 2.3±0.06µs 2.3±0.08µs 0.00%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ケ﨑東池ノ内町 1517.7±24.15ns 1528.6±36.46ns +0.72%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ヶ崎東池ノ内町 296.5±6.66ns 296.8±7.18ns +0.10%

@YuukiToriyama YuukiToriyama marked this pull request as ready for review October 31, 2024 15:41
@YuukiToriyama YuukiToriyama merged commit e69d1f0 into feature/chimei-ruiju/master Oct 31, 2024
7 checks passed
@YuukiToriyama YuukiToriyama deleted the feature/chimei-ruiju/fix-clippy-warnings branch October 31, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant