Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chimei-ruiju.orgへの対応: Parser#parse_with_chimeiruijuに対するテストコードを修正 #493

Conversation

YuukiToriyama
Copy link
Owner

変更点

  • chimei-ruiju.orgへの対応 #426
  • ChimeiRuijuではなくGeoloniaのデータを使うテストになっており、意図が異なるテストになっていたため修正します。

ChimeiRuijuではなくGeoloniaのデータを使うテストになっていたため
@YuukiToriyama YuukiToriyama self-assigned this Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Benchmark for 3f73c43

Click to view benchmark
Test Base PR %
orthographical_variant_adapter/松ケ崎東池ノ内町/松が崎東池ノ内町 428.2±14.41ns 436.8±36.50ns +2.01%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ガ﨑東池の内町 2.3±0.02µs 2.3±0.05µs 0.00%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ケ﨑東池の内町 2.3±0.04µs 2.4±0.06µs +4.35%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ケ﨑東池ノ内町 1500.9±15.88ns 1518.4±53.46ns +1.17%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ヶ崎東池ノ内町 286.3±3.68ns 291.9±3.73ns +1.96%

@YuukiToriyama YuukiToriyama marked this pull request as ready for review November 1, 2024 16:09
@YuukiToriyama YuukiToriyama merged commit 9ef5d15 into feature/chimei-ruiju/master Nov 1, 2024
7 checks passed
@YuukiToriyama YuukiToriyama deleted the feature/chimei-ruiju/fix-test-code branch November 1, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant