Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chimei-ruiju.orgへの対応: 住所のパースに成功した場合に位置情報をParsedAddressに含めるようにする #494

Conversation

YuukiToriyama
Copy link
Owner

@YuukiToriyama YuukiToriyama commented Nov 1, 2024

変更点

  • chimei-ruiju.orgへの対応 #426
  • ChimeiRuijuデータの都道府県マスタ・市区町村マスタ・町村マスタでそれぞれの地域の代表点の緯度経度を取得することができます。
  • 住所のパースに成功した場合、その地域の緯度経度情報をParsedAddressに含めるようにします。

備考

  • この修正により、experimental::Parserを用いて簡易的なジオコーディングが可能になります。

@YuukiToriyama YuukiToriyama self-assigned this Nov 1, 2024
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Benchmark for 9d1f29c

Click to view benchmark
Test Base PR %
orthographical_variant_adapter/松ケ崎東池ノ内町/松が崎東池ノ内町 419.4±4.72ns 419.8±11.25ns +0.10%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ガ﨑東池の内町 2.2±0.05µs 2.2±0.04µs 0.00%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ケ﨑東池の内町 2.3±0.02µs 2.3±0.02µs 0.00%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ケ﨑東池ノ内町 1486.1±32.81ns 1493.7±91.58ns +0.51%
orthographical_variant_adapter/松ケ崎東池ノ内町/松ヶ崎東池ノ内町 283.3±2.80ns 283.5±7.57ns +0.07%

@YuukiToriyama YuukiToriyama marked this pull request as ready for review November 2, 2024 08:55
@YuukiToriyama YuukiToriyama merged commit 26027b3 into feature/chimei-ruiju/master Nov 2, 2024
7 checks passed
@YuukiToriyama YuukiToriyama deleted the feature/chimei-ruiju/include-latlng-data branch November 2, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant