fix: outputs order is wrong when more than 1 outputs #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's wrong?
With computation returning more than 1 outputs, we get the wrong order of outputs. For example, the computation like this
results in outputs like
where
1
is the boolean for verifiers to check the result is accurate enough. It is wrong since1
should always be the first return value of a computationThe issue is that we return
is_precise_aggregated, op.result+(x[0]-x[0])[0][0]
for the last operation. However, the return value of a computation is not necessarily the return value of the last operation. For example,the last operation is
state.median(y)
but the return value isstate.mean(x), state.median(y)
. In our original approach, we'll returnres_mean, is_precise_aggregated, res_median
.How it's fixed?
Instead of returning the
is_precise_aggregated
in State.call_ops, we do it in theModel.forward