Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong handling of stock prices exceeding 1000 #7

Merged
merged 1 commit into from
May 30, 2021

Conversation

guijdp
Copy link
Contributor

@guijdp guijdp commented May 30, 2021

The regex expression to extract the unitary value of each stock doesn't treat the case when unitary stock price exceeds 1000.
Current expression separates the value into 2 matches:
Example: Value = 2,613.00 EUR => Regex Result [ 2 , 613.00 ] which renders stock value = 2 at the end

image

@Zarathustra2
Copy link
Owner

Thanks, I think this is related to #6

@Zarathustra2 Zarathustra2 merged commit d385c33 into Zarathustra2:master May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants