server: add sessions timeouts #386
Merged
+154
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
conradoplg
force-pushed
the
key-auth-cleanup
branch
from
74f9d2d to
326f323
Compare
conradoplg
force-pushed
the
session-timeout
branch
from
b268e5b to
3c42172
Compare
conradoplg
force-pushed
the
session-timeout
branch
from
3c42172 to
998c204
Compare
|
I'm admin-merging this to get things going. We can do an overall review/testing pass when we finish the current scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #383
Closes #375
This adds sessions timeouts, and fixes the existing timeouts which weren't being enforced.
I tested this manually; change the session or access token to e.g. 10 seconds, start the server, start a coordinator and wait. It will eventually error out due to the session or access token timing out.
We can add a proper test later on.