frost-client: support multiple sessions #399
Merged
+159
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradoplg
force-pushed
the
key-auth-cleanup
branch
from
74f9d2d to
326f323
Compare
conradoplg
force-pushed
the
multiple-sessions
branch
from
4c539c3 to
da0db42
Compare
conradoplg
force-pushed
the
multiple-sessions
branch
from
da0db42 to
9a3ed3d
Compare
|
I'm admin-merging this to get things going. We can do an overall review/testing pass when we finish the current scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #179
Closes #376
Allows listing sessions, and specifying which session to use.
Choosing which session to use can be still confusing if e.g. there are multiple sessions with the same coordinator and participants. At the end of the day what truly matters is the message being signed, and that is only sent in round 2. I think we can ignore this for now (I don't think people will have dozens of concurrent FROST signing sessions) but we might want to revisit this issue later.