Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Marek <mail@marek.onl>
  • Loading branch information
gustavovalverde and upbqdn authored Jun 10, 2024
1 parent fd3ca59 commit 181f478
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-tests.patch-external.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
#! `ci-tests.patch.yml` and `ci-tests.patch-external.yml` must be kept in sync.
jobs:
build:
name: Build CI Docker / Build images
name: Build CI Docker / Build CI image
# Only run on PRs from external repositories.
if: ${{ startsWith(github.event_name, 'pull') && github.event.pull_request.head.repo.fork }}
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-tests.patch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ on:
#! `ci-tests.patch.yml` and `ci-tests.patch-external.yml` must be kept in sync.
jobs:
build:
name: Build CI Docker / Build images
name: Build CI Docker / Build CI image
runs-on: ubuntu-latest
steps:
- run: 'echo "No build required"'
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/ci-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ on:
default: false

pull_request:
# Skip PRs where Rust code and dependencies aren't modified.
# Run only on PRs that modify Rust code or dependencies.
paths:
# code and tests
- "**/*.rs"
Expand All @@ -67,12 +67,14 @@ on:
- "docker/**"
- ".dockerignore"
- ".github/workflows/ci-tests.yml"
- ".github/workflows/sub-ci-unit-tests-docker.yml"
- ".github/workflows/sub-ci-integration-tests-gcp.yml"
- ".github/workflows/sub-deploy-integration-tests-gcp.yml"
- ".github/workflows/sub-find-cached-disks.yml"
- ".github/workflows/sub-build-docker-image.yml"

push:
# Skip main branch updates where Rust code and dependencies aren't modified.
# Run only on main branch updates that modify Rust code or dependencies.
branches:
- main
paths:
Expand Down

0 comments on commit 181f478

Please sign in to comment.