From 181f4787756683bc1abec3523d4d93b17a354d09 Mon Sep 17 00:00:00 2001 From: Gustavo Valverde Date: Mon, 10 Jun 2024 09:57:02 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Marek --- .github/workflows/ci-tests.patch-external.yml | 2 +- .github/workflows/ci-tests.patch.yml | 2 +- .github/workflows/ci-tests.yml | 6 ++++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci-tests.patch-external.yml b/.github/workflows/ci-tests.patch-external.yml index 01e35a89b8d..c40ff55f145 100644 --- a/.github/workflows/ci-tests.patch-external.yml +++ b/.github/workflows/ci-tests.patch-external.yml @@ -13,7 +13,7 @@ on: #! `ci-tests.patch.yml` and `ci-tests.patch-external.yml` must be kept in sync. jobs: build: - name: Build CI Docker / Build images + name: Build CI Docker / Build CI image # Only run on PRs from external repositories. if: ${{ startsWith(github.event_name, 'pull') && github.event.pull_request.head.repo.fork }} runs-on: ubuntu-latest diff --git a/.github/workflows/ci-tests.patch.yml b/.github/workflows/ci-tests.patch.yml index b5e410b234b..7301612b4ad 100644 --- a/.github/workflows/ci-tests.patch.yml +++ b/.github/workflows/ci-tests.patch.yml @@ -34,7 +34,7 @@ on: #! `ci-tests.patch.yml` and `ci-tests.patch-external.yml` must be kept in sync. jobs: build: - name: Build CI Docker / Build images + name: Build CI Docker / Build CI image runs-on: ubuntu-latest steps: - run: 'echo "No build required"' diff --git a/.github/workflows/ci-tests.yml b/.github/workflows/ci-tests.yml index d86e7eb1530..7d371d130c0 100644 --- a/.github/workflows/ci-tests.yml +++ b/.github/workflows/ci-tests.yml @@ -49,7 +49,7 @@ on: default: false pull_request: - # Skip PRs where Rust code and dependencies aren't modified. + # Run only on PRs that modify Rust code or dependencies. paths: # code and tests - "**/*.rs" @@ -67,12 +67,14 @@ on: - "docker/**" - ".dockerignore" - ".github/workflows/ci-tests.yml" + - ".github/workflows/sub-ci-unit-tests-docker.yml" + - ".github/workflows/sub-ci-integration-tests-gcp.yml" - ".github/workflows/sub-deploy-integration-tests-gcp.yml" - ".github/workflows/sub-find-cached-disks.yml" - ".github/workflows/sub-build-docker-image.yml" push: - # Skip main branch updates where Rust code and dependencies aren't modified. + # Run only on main branch updates that modify Rust code or dependencies. branches: - main paths: