Skip to content

Commit

Permalink
Change checklist phrasing so the answer is yes when the PR is complete
Browse files Browse the repository at this point in the history
  • Loading branch information
teor2345 authored Oct 26, 2023
1 parent a87a948 commit 2dff2b3
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ _What are the most important goals of the ticket or PR?_

Check before marking the PR as ready for review:
- [ ] Will the PR name make sense to users?
- [ ] Does it need extra CHANGELOG info?
- [ ] For significant changes: Is there a summary in the CHANGELOG?
- [ ] Does the PR have a priority label?
- [ ] Have you added or updated tests?
- [ ] Is the documentation up to date?
Expand Down Expand Up @@ -58,8 +58,8 @@ If you want specific reviewers for this PR, tag them here.
Check before approving the PR:
- [ ] Does the PR scope match the ticket?
- [ ] How do you know it works? Do the tests cover the PR motivation?
- [ ] Are there any blockers to merging this PR?
- [ ] Can some changes go in new tickets or PRs?
- [ ] Are all the PR blockers dealt with?
PR blockers can be dealt with in new tickets or PRs.

_And check the PR Author checklist is complete._

Expand Down

0 comments on commit 2dff2b3

Please sign in to comment.