Skip to content

Commit

Permalink
fix(build): always login to DockerHub
Browse files Browse the repository at this point in the history
  • Loading branch information
gustavovalverde committed Mar 22, 2024
1 parent bf3ed06 commit 87742bc
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/sub-build-docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ jobs:
uses: docker/metadata-action@v5.5.1
with:
# list of Docker images to use as base name for tags
# We only publish images to DockerHub if a release is not a pre-release
# Ref: https://github.com/orgs/community/discussions/26281#discussioncomment-3251177
images: |
us-docker.pkg.dev/${{ vars.GCP_PROJECT }}/zebra/${{ inputs.image_name }}
zfnd/${{ inputs.image_name }},enable=${{ github.event_name == 'release' && !github.event.release.prerelease }}
Expand Down Expand Up @@ -139,9 +141,6 @@ jobs:
password: ${{ steps.auth.outputs.access_token }}

- name: Login to DockerHub
# We only publish images to DockerHub if a release is not a pre-release
# Ref: https://github.com/orgs/community/discussions/26281#discussioncomment-3251177
if: ${{ github.event_name == 'release' && !github.event.release.prerelease }}
uses: docker/login-action@v3.1.0
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
Expand Down

0 comments on commit 87742bc

Please sign in to comment.