Limit random heights to database range

ZcashFoundation · Dec 7, 2023 · 8ac73c3 · 8ac73c3
1 parent 5dcad35
commit 8ac73c3
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/zebra-state/src/service/finalized_state/disk_format/scan/tests/prop.rs b/zebra-state/src/service/finalized_state/disk_format/scan/tests/prop.rs
@@ -4,7 +4,7 @@ use proptest::{arbitrary::any, prelude::*};
 
 use crate::{
     service::finalized_state::arbitrary::assert_value_properties, SaplingScannedDatabaseIndex,
-    SaplingScannedResult, SaplingScanningKey,
+    SaplingScannedResult, SaplingScanningKey, MAX_ON_DISK_HEIGHT,
 };
 
 #[test]
@@ -18,7 +18,15 @@ fn roundtrip_sapling_scanning_key() {
 fn roundtrip_sapling_db_index() {
     let _init_guard = zebra_test::init();
 
-    proptest!(|(val in any::<SaplingScannedDatabaseIndex>())| assert_value_properties(val));
+    proptest!(
+        |(mut val in any::<SaplingScannedDatabaseIndex>())| {
+            // Limit the random height to the valid on-disk range.
+            // Blocks outside this range are rejected before they reach the state.
+            // (It would take decades to generate a valid chain this high.)
+            val.tx_loc.height.0 %= MAX_ON_DISK_HEIGHT.0 + 1;
+            assert_value_properties(val)
+        }
+    );
 }
 
 #[test]