bug: "failed to make outbound connection" logs are confusing to users

[teor2345]

Motivation

We had a user who was confused about the peer connection failure logs, they thought it might be causing their RPC issues. Since these logs are expected, we might want to make them debug-level.

The first log might be useful if there's no internet connectivity. But having lots of these logs is just confusing.

If we keep any of these logs, they would be less confusing if they were worded differently, and contained less information.

Examples

2023-11-21T04:29:59.610498Z INFO {net="Main"}:crawl_and_dial{new_peer_interval=61s}:dial{candidate=MetaAddr { addr: v4redacted:8233, services: Some(PeerServices(NODE_NETWORK)), untrusted_last_seen: Some(DateTime32 { timestamp: 1700532920, calendar: 2023-11-21T02:15:20Z }), last_response: None, last_attempt: Some(Instant { tv_sec: 21274497, tv_nsec: 682694834 }), last_failure: None, last_connection_state: AttemptPending }}: zebra_network::peer_set::initialize: failed to make outbound connection to peer error=Elapsed(()) candidate.addr=v4redacted:8233
2023-11-21T04:30:01.062593Z INFO {net="Main"}:sync:try_to_sync:try_to_sync_once{extra_hashes={}}: zebrad::components::sync: extending tips tips.len=1 in_flight=999 extra_hashes=0 lookahead_limit=1000 state_tip=Some(Height(5600))

This log is more useful and a better summary:

2023-11-21T04:28:47.623170Z INFO {net="Main"}:add_initial_peers: zebra_network::peer_set::initialize: an initial peer connection failed successes=0 errors=1 addr=v6redacted:8233 e=Network is unreachable
(os error 101)

Specifications

No response

Complex Code or Requirements

No response

Testing

Run Zebra and check for these logs.

Related Work

No response

[teor2345]

This was done in PR #8072