Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scanner should log a message when Zebra is before the Sapling activation block #8041

Closed
teor2345 opened this issue Dec 3, 2023 · 0 comments · Fixed by #8121
Closed

Scanner should log a message when Zebra is before the Sapling activation block #8041

teor2345 opened this issue Dec 3, 2023 · 0 comments · Fixed by #8121
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-cleanup Category: This is a cleanup C-testing Category: These are tests

Comments

@teor2345
Copy link
Contributor

teor2345 commented Dec 3, 2023

I think we should print a message as soon as we know we are behind the sapling activation block saying something as:

"scan task will not get started until the blockchain is at sapling activation height (block number: {sapling activation_height})"

This way users will know the scanner will do nothing until that.

We can look for that message in this test so it will not require further modifications. A new test will be done with state.

Originally posted by @oxarbitrage in #8040 (comment)

@mpguerra mpguerra added this to Zebra Dec 3, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Dec 3, 2023
@teor2345 teor2345 added C-cleanup Category: This is a cleanup P-Low ❄️ C-testing Category: These are tests A-blockchain-scanner Area: Blockchain scanner of shielded transactions and removed P-Optional ✨ labels Dec 3, 2023
@mergify mergify bot closed this as completed in #8121 Dec 21, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-cleanup Category: This is a cleanup C-testing Category: These are tests
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant