Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump ECC dependencies #7784

Merged
merged 3 commits into from
Oct 20, 2023
Merged

build(deps): bump ECC dependencies #7784

merged 3 commits into from
Oct 20, 2023

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented Oct 19, 2023

Motivation

With zcash_script updated we can bump ECC dependencies.

Solution

cargo upgrade --incompatible -p bridgetree -p incrementalmerkletree -p orchard -p zcash_primitives@0.13.0-rc.1 -p zcash_proofs@0.13.0-rc.1 -p zcash_script

Review

Draft until CI passes.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

Documenting the upgrade process will follow. #6532

@oxarbitrage oxarbitrage added P-Medium ⚡ A-compatibility Area: Compatibility with other nodes or wallets, or standard rules labels Oct 19, 2023
@oxarbitrage oxarbitrage self-assigned this Oct 19, 2023
@github-actions github-actions bot added C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 19, 2023
@oxarbitrage oxarbitrage removed the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 19, 2023
@teor2345 teor2345 marked this pull request as ready for review October 19, 2023 23:22
@teor2345 teor2345 requested review from a team as code owners October 19, 2023 23:22
@teor2345 teor2345 requested review from upbqdn and teor2345 and removed request for a team October 19, 2023 23:22
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 19, 2023
@teor2345 teor2345 added A-dependencies Area: Dependency file updates and removed C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 19, 2023
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems pretty straightforward on the Zebra side!

mergify bot added a commit that referenced this pull request Oct 20, 2023
@mergify mergify bot merged commit 9c993f8 into main Oct 20, 2023
104 checks passed
@mergify mergify bot deleted the issue7535 branch October 20, 2023 02:12
@mpguerra mpguerra linked an issue Oct 20, 2023 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-dependencies Area: Dependency file updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade dependencies for zcashd 5.7.0
2 participants