Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable macOS builds and tests in CI #7834

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Re-enable macOS builds and tests in CI #7834

merged 2 commits into from
Oct 26, 2023

Conversation

oxarbitrage
Copy link
Contributor

@oxarbitrage oxarbitrage commented Oct 25, 2023 •
edited
Loading

Motivation

This is a test to see if macos tests pass the CI as they are passing with a mac locally. See #6812 (comment)

Close #6812

Solution

Revert #6825

Review

Should be merged if CI passes.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

@oxarbitrage oxarbitrage self-assigned this Oct 25, 2023
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 25, 2023
@oxarbitrage oxarbitrage marked this pull request as ready for review October 26, 2023 00:54
@oxarbitrage oxarbitrage requested a review from a team as a code owner October 26, 2023 00:54
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team October 26, 2023 00:54
@oxarbitrage oxarbitrage added A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-devops Area: Pipelines, CI/CD and Dockerfiles P-Low ❄️ C-testing Category: These are tests I-build-fail Zebra fails to build and removed C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-compatibility Area: Compatibility with other nodes or wallets, or standard rules labels Oct 26, 2023
mergify bot added a commit that referenced this pull request Oct 26, 2023
@mergify
Merge of #7834
c3c69c4
@mergify mergify bot mentioned this pull request Oct 26, 2023
Closed
@mergify mergify bot merged commit 879fd5f into main Oct 26, 2023
82 checks passed
@mergify mergify bot deleted the issue6812 branch October 26, 2023 12:48
This was referenced Oct 26, 2023
Merged
Closed
@teor2345 teor2345 changed the title Revert #6825 Re-enable macOS builds and tests in CI Oct 26, 2023
@teor2345
Copy link
Contributor

I renamed this PR, but I'm not sure if that will be reflected in the draft changelog. If not I'll update the name when I write the changelog.

@teor2345 teor2345 mentioned this pull request Oct 31, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upbqdn upbqdn upbqdn approved these changes

Assignees

@oxarbitrage oxarbitrage

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-testing Category: These are tests I-build-fail Zebra fails to build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Process abort in state tests on some macOS versions with Rust 1.70
3 participants
@oxarbitrage @teor2345 @upbqdn