-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zebra-scan): Connect with zebrad #7989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what errors you're getting, so I've tried to make some suggestions about what it could be.
I can also look at the specific error if you post the code or the error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, since this is blocking other work, let's merge and replace things later.
I just quickly removed the panic that happens when the state is empty.
Motivation
We want to pass the keys that are in the config from zebrad to zebra-scan at node startup.
Close #7946
PR Author Checklist
Check before marking the PR as ready for review:
Solution
zebrad/src/comamnds/start.rs
aStorage
RAM database is created and the keys are dumped into it form config. Then the scan task is spawned with the created storage instance and the state.zebra-scan/src/scan.rs
. The task just print some logs at the moment for testing purposes.Testing
zebrad/test/accpentance.rs
.Review
I think anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work