change(ci): When building crates individually, build all targets, and run clippy #8024
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There are some build failures that only show up when the tests are built in an individual crate. This impacts Zebra's usability for external developers.
This PR runs clippy and builds all targets in all crates individually. Then it fixes any errors that turn up.
This is related to #8019 and the scanner work in general, but these errors could happen in any crate.
PR Author Checklist
Check before marking the PR as ready for review:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
zebrad
test build takes more than 14 GB disk spaceRelated cleanups:
Admin:
Testing
This PR fixes and adds tests.
Review
This is urgent because it will cause merge conflicts with upcoming changes.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.