change(zebra-scan): Scan only one key per backend call #8034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to scan only one key and one block per call to the
zcash_client_backend::scanning::scan_block
function.The call support scanning a list of keys which it should be more efficient but we can't relate transaction with key in the results.
Close #8018
PR Author Checklist
Check before marking the PR as ready for review:
Solution
Replace the list argument of the zebra zcan_block function with single key element.
The
scanning_from_populated_zebra_state
test case was removed because after the change no empty key will be allowed and the account/nullifier method to scan is not supported; by that the test ends up being the same asscanning_zecpages_from_populated_zebra_state
Testing
Change covered by existing
scanning_zecpages_from_populated_zebra_state
test, after minor modifications to the call argument.Review
Anyone can review.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.
Follow Up Work