Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scan): Start scanning task only if there are keys to scan #8059

Merged
merged 2 commits into from
Dec 6, 2023
Merged

fix(scan): Start scanning task only if there are keys to scan #8059

merged 2 commits into from
Dec 6, 2023

Conversation

oxarbitrage
Copy link
Contributor

Motivation

Part of #7892

When we run the Zebra test suite some tests will fail with database already in use. It seems a bug in shutdown. We want to run the scan tests and config tests so we can lock that functionality and keep making progress.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

Solution

  • Start scan only if there are keys.
  • Fix config test for new config file that is generated when shielded-scan feature is enabled.
  • Add ephemeral database in tests by default.

Review

Anyone can review.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

Follow Up Work

@oxarbitrage oxarbitrage added C-bug Category: This is a bug P-Medium ⚡ A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Dec 5, 2023
@oxarbitrage oxarbitrage requested a review from a team as a code owner December 5, 2023 23:37
@oxarbitrage oxarbitrage requested review from upbqdn and removed request for a team December 5, 2023 23:37
@github-actions github-actions bot added C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Dec 5, 2023
@oxarbitrage oxarbitrage self-assigned this Dec 5, 2023
teor2345
teor2345 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes!

mergify bot added a commit that referenced this pull request Dec 6, 2023
@mergify
Merge of #8059
982167c
@mergify mergify bot mentioned this pull request Dec 6, 2023
Closed
@mergify mergify bot merged commit cdfbecf into main Dec 6, 2023
181 checks passed
@mergify mergify bot deleted the shielded-scanning-feat-fix-tests branch December 6, 2023 01:56
@teor2345 teor2345 mentioned this pull request Dec 7, 2023
Closed
2 tasks
@mpguerra mpguerra linked an issue Dec 11, 2023 that may be closed by this pull request
change(release): Enable all user features in the experimental build #7892
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@upbqdn upbqdn Awaiting requested review from upbqdn upbqdn is a code owner automatically assigned from ZcashFoundation/general-rust-reviewers

Assignees

@oxarbitrage oxarbitrage

Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions C-bug Category: This is a bug C-feature Category: New features C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

change(release): Enable all user features in the experimental build
2 participants
@oxarbitrage @teor2345