Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(log): Silence verbose failed connection logs #8072

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Dec 6, 2023

Motivation

  1. Having lots of failed connection logs makes Zebra less usable, but when there are only a few connections users need to know why
  2. It's also causing GitHub to be very slow showing logs in tests

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • In production, log failed connections at info level at startup, and when there are less than 5 connections
  • In tests, always log failed connections at debug level (except maybe for startup)

Review

This is a low priority logging fix.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@teor2345 teor2345 added C-bug Category: This is a bug P-Low ❄️ I-usability Zebra is hard to understand or use A-network Area: Network protocol updates or fixes A-diagnostics Area: Diagnosing issues or monitoring performance C-testing Category: These are tests labels Dec 6, 2023
@teor2345 teor2345 self-assigned this Dec 6, 2023
@teor2345 teor2345 requested a review from a team as a code owner December 6, 2023 23:07
@teor2345 teor2345 requested review from arya2 and removed request for a team December 6, 2023 23:07
arya2
arya2 previously approved these changes Dec 7, 2023
Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

zebra-network/src/peer_set/initialize.rs Outdated Show resolved Hide resolved
@mergify mergify bot merged commit 6306a75 into main Dec 7, 2023
128 checks passed
@mergify mergify bot deleted the less-conn-logs branch December 7, 2023 03:34
@arya2 arya2 mentioned this pull request Dec 7, 2023
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance A-network Area: Network protocol updates or fixes C-bug Category: This is a bug C-testing Category: These are tests I-usability Zebra is hard to understand or use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants