Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(doc): Update docs in scan.rs #8073

Closed
wants to merge 1 commit into from
Closed

change(doc): Update docs in scan.rs #8073

wants to merge 1 commit into from

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Dec 7, 2023

Motivation

I added some docs to the scanner module.

This is mostly a test for ticket #8037.

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

If a checkbox isn't relevant to the PR, mark it as done.

Review

This change is optional.

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@teor2345 teor2345 added A-docs Area: Documentation C-cleanup Category: This is a cleanup P-Optional ✨ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Dec 7, 2023
@teor2345 teor2345 self-assigned this Dec 7, 2023
@teor2345
Copy link
Contributor Author

teor2345 commented Dec 7, 2023

This PR passed so it has achieved its purpose.

@teor2345 teor2345 closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-docs Area: Documentation C-cleanup Category: This is a cleanup C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant