Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(scan): Impl From<SaplingScannedResult> for [u8; 32] #8077

Closed
wants to merge 1 commit into from

Conversation

upbqdn
Copy link
Member

@upbqdn upbqdn commented Dec 8, 2023

Motivation

This is a trivial PR that adds From<SaplingScannedResult> for [u8; 32].

PR Author Checklist

Check before marking the PR as ready for review:

  • Will the PR name make sense to users?
  • Does the PR have a priority label?
  • Have you added or updated tests?
  • Is the documentation up to date?

If a checkbox isn't relevant to the PR, mark it as done.

Solution

  • Impl From<SaplingScannedResult> for [u8; 32].

Review

Reviewer Checklist

Check before approving the PR:

  • Does the PR scope match the ticket?
  • Are there enough tests to make sure it works? Do the tests cover the PR motivation?
  • Are all the PR blockers dealt with?
    PR blockers can be dealt with in new tickets or PRs.

And check the PR Author checklist is complete.

@upbqdn upbqdn added A-rust Area: Updates to Rust code P-Low ❄️ C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG A-blockchain-scanner Area: Blockchain scanner of shielded transactions labels Dec 8, 2023
@upbqdn upbqdn self-assigned this Dec 8, 2023
@upbqdn upbqdn requested a review from a team as a code owner December 8, 2023 16:40
@upbqdn upbqdn requested review from oxarbitrage and removed request for a team December 8, 2023 16:40
@upbqdn upbqdn closed this Dec 11, 2023
@upbqdn upbqdn deleted the impl-from-scanned-results branch December 11, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-blockchain-scanner Area: Blockchain scanner of shielded transactions A-rust Area: Updates to Rust code C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants