Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cd): add external static IPs to release nodes #8891

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

chore: remove extra file

ce5cdbc
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Draft

feat(cd): add external static IPs to release nodes #8891

chore: remove extra file
ce5cdbc
Select commit
Loading
Failed to load commit list.
GitHub Actions / actionlint completed Dec 26, 2024 in 1s

reviewdog [actionlint] report

reported by reviewdog 🐶

Findings (2)

.github/workflows/cd-deploy-nodes-gcp.yml|291 col 9| shellcheck reported issue in this script: SC2129:style:2:1: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|301 col 9| shellcheck reported issue in this script: SC2086:info:1:60: Double quote to prevent globbing and word splitting [shellcheck]

Filtered Findings (43)

.github/workflows/cd-deploy-nodes-gcp.yml|304 col 9| shellcheck reported issue in this script: SC2078:error:11:8: This expression is constant. Did you forget a $ somewhere? [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|304 col 9| shellcheck reported issue in this script: SC2086:info:18:165: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|304 col 9| shellcheck reported issue in this script: SC2086:info:27:66: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|304 col 9| shellcheck reported issue in this script: SC2086:info:35:49: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|424 col 9| shellcheck reported issue in this script: SC2078:error:5:8: This expression is constant. Did you forget a $ somewhere? [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|424 col 9| shellcheck reported issue in this script: SC2086:info:19:66: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|424 col 9| shellcheck reported issue in this script: SC2086:info:27:44: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/cd-deploy-nodes-gcp.yml|424 col 486| property "network" is not defined in object type {} [expression]
.github/workflows/ci-build-crates.patch.yml|44 col 9| shellcheck reported issue in this script: SC2005:style:2:6: Useless echo? Instead of 'echo $(cmd)', just use 'cmd' [shellcheck]
.github/workflows/ci-build-crates.patch.yml|44 col 9| shellcheck reported issue in this script: SC2086:info:2:179: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.patch.yml|44 col 9| shellcheck reported issue in this script: SC2005:style:5:8: Useless echo? Instead of 'echo $(cmd)', just use 'cmd' [shellcheck]
.github/workflows/ci-build-crates.patch.yml|44 col 9| shellcheck reported issue in this script: SC2086:info:5:15: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.patch.yml|44 col 9| shellcheck reported issue in this script: SC2086:info:8:6: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.patch.yml|44 col 9| shellcheck reported issue in this script: SC2086:info:9:6: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.yml|83 col 9| shellcheck reported issue in this script: SC2086:info:2:195: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.yml|83 col 9| shellcheck reported issue in this script: SC2005:style:5:8: Useless echo? Instead of 'echo $(cmd)', just use 'cmd' [shellcheck]
.github/workflows/ci-build-crates.yml|83 col 9| shellcheck reported issue in this script: SC2086:info:5:15: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.yml|83 col 9| shellcheck reported issue in this script: SC2086:info:8:6: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.yml|83 col 9| shellcheck reported issue in this script: SC2086:info:9:6: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-build-crates.yml|116 col 14| label "ubuntu-latest-m" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/ci-coverage.yml|69 col 14| label "ubuntu-latest-xl" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/ci-coverage.yml|87 col 9| shellcheck reported issue in this script: SC2086:info:1:38: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-coverage.yml|95 col 9| shellcheck reported issue in this script: SC2086:info:1:28: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-coverage.yml|95 col 9| shellcheck reported issue in this script: SC2086:info:2:39: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-unit-tests-os.yml|143 col 9| shellcheck reported issue in this script: SC2028:info:2:6: echo may not expand escape sequences. Use printf [shellcheck]
.github/workflows/ci-unit-tests-os.yml|143 col 9| shellcheck reported issue in this script: SC2086:info:2:55: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-unit-tests-os.yml|143 col 9| shellcheck reported issue in this script: SC2028:info:3:6: echo may not expand escape sequences. Use printf [shellcheck]
.github/workflows/ci-unit-tests-os.yml|143 col 9| shellcheck reported issue in this script: SC2086:info:3:69: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-unit-tests-os.yml|153 col 9| shellcheck reported issue in this script: SC2086:info:1:38: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-unit-tests-os.yml|163 col 9| shellcheck reported issue in this script: SC2086:info:1:28: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/ci-unit-tests-os.yml|163 col 9| shellcheck reported issue in this script: SC2086:info:2:42: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/manual-zcashd-deploy.yml|65 col 9| shellcheck reported issue in this script: SC2086:info:14:46: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/sub-ci-unit-tests-docker.yml|46 col 14| label "ubuntu-latest-xl" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/sub-deploy-integration-tests-gcp.yml|130 col 14| label "zfnd-runners" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/sub-deploy-integration-tests-gcp.yml|188 col 9| shellcheck reported issue in this script: SC2086:info:18:62: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/sub-deploy-integration-tests-gcp.yml|258 col 9| shellcheck reported issue in this script: SC2016:info:6:11: Expressions don't expand in single quotes, use double quotes for that [shellcheck]
.github/workflows/sub-deploy-integration-tests-gcp.yml|289 col 9| shellcheck reported issue in this script: SC2016:info:6:11: Expressions don't expand in single quotes, use double quotes for that [shellcheck]
.github/workflows/sub-deploy-integration-tests-gcp.yml|343 col 9| shellcheck reported issue in this script: SC2016:info:6:11: Expressions don't expand in single quotes, use double quotes for that [shellcheck]
.github/workflows/sub-find-cached-disks.yml|105 col 9| shellcheck reported issue in this script: SC2129:style:2:1: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]
.github/workflows/sub-test-zebra-config.yml|39 col 14| label "ubuntu-latest-m" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-14.0", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-13.0", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "macos-12.0", "macos-11", "macos-11.0", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file [runner-label]
.github/workflows/sub-test-zebra-config.yml|53 col 9| shellcheck reported issue in this script: SC2086:info:26:10: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/sub-test-zebra-config.yml|53 col 9| shellcheck reported issue in this script: SC2086:info:26:38: Double quote to prevent globbing and word splitting [shellcheck]
.github/workflows/sub-test-zebra-config.yml|53 col 9| shellcheck reported issue in this script: SC2086:info:30:14: Double quote to prevent globbing and word splitting [shellcheck]

Annotations

Check warning on line 291 in .github/workflows/cd-deploy-nodes-gcp.yml

See this annotation in the file changed.

@github-actions github-actions / actionlint

[actionlint] .github/workflows/cd-deploy-nodes-gcp.yml#L291

shellcheck reported issue in this script: SC2129:style:2:1: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]
Raw output
.github/workflows/cd-deploy-nodes-gcp.yml:291:9: shellcheck reported issue in this script: SC2129:style:2:1: Consider using { cmd1; cmd2; } >> file instead of individual redirects [shellcheck]

Check warning on line 301 in .github/workflows/cd-deploy-nodes-gcp.yml

See this annotation in the file changed.

@github-actions github-actions / actionlint

[actionlint] .github/workflows/cd-deploy-nodes-gcp.yml#L301

shellcheck reported issue in this script: SC2086:info:1:60: Double quote to prevent globbing and word splitting [shellcheck]
Raw output
.github/workflows/cd-deploy-nodes-gcp.yml:301:9: shellcheck reported issue in this script: SC2086:info:1:60: Double quote to prevent globbing and word splitting [shellcheck]