Suggestion for "feat(regtest): Add regtest halving interval and port test" #8921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reams, updates funding stream setter methods to set a flag indicating that parameters affecting the funding stream address period should be locked, updates the setter methods for parameters that affect the funding stream address period to panic if those parameters should be locked.
github-actions
bot
added
C-feature
7 tasks
arya2
commented
Oct 10, 2024
| @@ -231,6 +217,9 @@ pub struct ParametersBuilder { | |||
| pre_nu6_funding_streams: FundingStreams, | |||
| /// Post-NU6 funding streams for this network | |||
| post_nu6_funding_streams: FundingStreams, | |||
| /// A flag indicating whether to allow changes to fields that affect | |||
| /// the funding stream address period. | |||
| should_lock_funding_stream_address_period: bool, | |||
There was a problem hiding this comment.
This field and the related checks aren't strictly necessary if we want ParametersBuilder to be more flexible, it could be useful for debugging otherwise.
oxarbitrage
approved these changes
Oct 10, 2024
oxarbitrage
deleted the
custom-testnet-funding-stream-addr-period-check
branch
mergify bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
* add halving interval to regtest and to custom testnet * add nuparams.py rpc test * fix inconsistency in nu6 name in rpc methods * rename `halving_interval` to `pre_blossom_halving_interval` in the config * make fixes * Suggestion for "feat(regtest): Add regtest halving interval and port test" (#8894) * adds `height_for_halving_index()` and `num_halvings()` fns * avoid unnecessary panic * avoid using constant pre/post blossom halving intervals in num_halvings() * make regtest and testnet constant more private * move `height_for_halving_index` * fmt * add a `funding_stream_address_change_interval` method * add checked operations to `height_for_halving_index` fn * add post_blossom interval as paramneters + other refactors * rename function * fix docs * move constant * Updates `new_regtest()` method to return a Testnet without funding streams, updates funding stream setter methods to set a flag indicating that parameters affecting the funding stream address period should be locked, updates the setter methods for parameters that affect the funding stream address period to panic if those parameters should be locked. (#8921) --------- Co-authored-by: Arya <aryasolhi@gmail.com>
dmidem
pushed a commit
to QED-it/zebra
that referenced
this pull request
Oct 29, 2024
…ation#8888) * add halving interval to regtest and to custom testnet * add nuparams.py rpc test * fix inconsistency in nu6 name in rpc methods * rename `halving_interval` to `pre_blossom_halving_interval` in the config * make fixes * Suggestion for "feat(regtest): Add regtest halving interval and port test" (ZcashFoundation#8894) * adds `height_for_halving_index()` and `num_halvings()` fns * avoid unnecessary panic * avoid using constant pre/post blossom halving intervals in num_halvings() * make regtest and testnet constant more private * move `height_for_halving_index` * fmt * add a `funding_stream_address_change_interval` method * add checked operations to `height_for_halving_index` fn * add post_blossom interval as paramneters + other refactors * rename function * fix docs * move constant * Updates `new_regtest()` method to return a Testnet without funding streams, updates funding stream setter methods to set a flag indicating that parameters affecting the funding stream address period should be locked, updates the setter methods for parameters that affect the funding stream address period to panic if those parameters should be locked. (ZcashFoundation#8921) --------- Co-authored-by: Arya <aryasolhi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggestion PR for #8888 that addresses this comment by:
ParametersBuilderthat affect the funding stream address period after setting configured funding streams, andParametersBuilderare valid for the derived network's funding stream address period.@oxarbitrage can review and optionally merge it into their PR.