Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Qt apps failing to be identified as Qt #22

Open
modest opened this issue May 7, 2022 · 2 comments
Open

More Qt apps failing to be identified as Qt #22

modest opened this issue May 7, 2022 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@modest
Copy link

modest commented May 7, 2022

5GUIs incorrectly identifies these Qt apps as AppKit:

Tableau Desktop
VirtualBox
Blackmagic Desktop Video
Blackmagic RAW Player
Blackmagic RAW Speed Test
DaVinci Resolve

(I am horrified by the realization that DaVinci Resolve is a Qt app. It was supposed to save us from Premiere...)

@helje5
Copy link
Member

helje5 commented May 7, 2022

Awful. Should be fixed ASAP!

@helje5 helje5 added bug Something isn't working help wanted Extra attention is needed labels May 7, 2022
@modest
Copy link
Author

modest commented May 7, 2022

It looks like Qt detection currently looks for QtCore.framework.

With the exception of VirtualBox, these aren't being detected because they just have the Qt .dylib binaries tossed in the Frameworks folder, like libQt5Core.5.dylib

But I think what we actually want to detect is QtGui, which is the library that creates desktop windows, etc.

If you want exact filename matches, those are:
QtGui.framework and libQt5Gui.5.dylib (the .5.dylib is always constant for Qt 5)

VirtualBox is failing detection because it has forked Qt frameworks with different names (e.g. QtGuiVBox.framework)

Maybe a fuzzy search for .*Qt.?Gui.* ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants