Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

Update dependencies #303

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Update dependencies #303

wants to merge 3 commits into from

Conversation

Zemanzo
Copy link
Owner

@Zemanzo Zemanzo commented Sep 18, 2021

More dependency updates! Woo! Hopefully this also fixes any open security issues when it comes to dependencies.

Only Cookies had breaking changes that affected us, so that logic has been updated.

Discord.js is not updated in this PR because that's done in #301 of course.

@Zemanzo Zemanzo added the dependencies Pull requests that update a dependency file label Sep 18, 2021
@Zemanzo Zemanzo requested a review from Qaomen September 18, 2021 18:25
Copy link
Collaborator

@Qaomen Qaomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooh more dependency updates! Slightly less wooh is that the cookies and editor are borked, meaning I couldn't fully test the pako dependency update either. :(

}
}, false);

let userState = {
AUTH_CHANGED: 0,

data: Cookies.getJSON("user_data")
data: JSON.parse(Cookies.get("user_data"))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
When I logged out on the client page and refreshed, the page failed to load fully and got this in my console.

"reconnecting-websocket": "^4.4.0",
"request": "^2.88.0",
"request-promise-native": "^1.0.7",
"semver": "^7.1.0",
"stats-js": "^1.0.0",
"styled-components": "^5.1.0",
"three": "^0.123.0",
"three": "^0.132.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Three.js has breaking changes (which we get warnings about when building the client), causing the editor to break:
image

@Zemanzo
Copy link
Owner Author

Zemanzo commented Sep 20, 2021

Heck I'm so smart, probably didn't even rebuild the client after bumping version numbers but before testing.

Merlijn van der Kamp added 2 commits September 25, 2021 13:17
(Leaving it unset will be unsupported in the future, causing the cookie to be rejected)
- Also changed editorLog to have messages appear in the regular browser console too.
@Zemanzo Zemanzo requested a review from Qaomen September 25, 2021 15:31
@Zemanzo
Copy link
Owner Author

Zemanzo commented Sep 25, 2021

@Qaomen Actually before you approve this, try this map:
Beach2-alpha.zip

When you load it, the start & starting gate are slightly offset, until you click the world tab, which causes it to snap back to how they should be positioned.
Unfortunately, when playing the map, it seems the start is actually saved with the offset as marbles fall off the track when they are spawned. I had trouble with getting the _combineGeometry() function in models.js working nicely again whilst fixing dependency stuff. Maybe you could take a quick look and see what's wrong?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants