New feature : Csv Export #2273
New feature : Csv Export #2273
Conversation
package.json
Outdated
| @@ -31,6 +31,7 @@ | |||
| "fetch-libraries": "bash fetch-libraries.sh" | |||
| }, | |||
| "dependencies": { | |||
| "@json2csv/plainjs": "^7.0.6", | |||
There was a problem hiding this comment.
Lock the version here (remove ^ and run yarn again)
package.json
Outdated
| @@ -156,6 +157,7 @@ | |||
| "@babel/plugin-proposal-nullish-coalescing-operator": "7.18.6", | |||
| "@babel/plugin-proposal-optional-chaining": "7.21.0", | |||
| "@babel/plugin-transform-arrow-functions": "7.22.5", | |||
| "@babel/plugin-transform-export-namespace-from": "^7.24.7", | |||
|
We might have to change the file name from |
views/Activity/JsonToCsv.tsx
Outdated
| onChangeText={setCustomFileName} | ||
| /> | ||
| <View> | ||
| <Button title="Download CSV" onPress={downloadCsv} /> |
There was a problem hiding this comment.
this needs to be localized
There was a problem hiding this comment.
@Ajeett01 look through locale files and add your used strings here
|
Yup we can, or maybe |
views/Activity/Activity.tsx
Outdated
| type="feather" | ||
| color={themeColor('text')} | ||
| underlayColor="transparent" | ||
| size={30} |
There was a problem hiding this comment.
adjust the download icon size here as compared to filter and cross icons
| 'react-native-reanimated/plugin', | ||
| ['@babel/plugin-transform-export-namespace-from'] | ||
| ] |
There was a problem hiding this comment.
why have we added that?
There was a problem hiding this comment.
I am curious about this too
views/Activity/JsonToCsv.tsx
Outdated
| if (!csv) return; | ||
|
|
||
| try { | ||
| if (Platform.OS === 'android') { |
There was a problem hiding this comment.
we are not yet handling the downloading for iOS right ?
views/Activity/JsonToCsv.tsx
Outdated
| 'cltv_expiry', | ||
| 'creation_date', | ||
| 'expiry' | ||
| ]; |
There was a problem hiding this comment.
@kaloudis would these keys be good to download in our csv data?
There was a problem hiding this comment.
these look ok, definitely need to flesh them out though
views/Activity/ActivityToCsv.tsx
Outdated
| message: 'This app needs access to your storage to save CSV files', | ||
| buttonNeutral: 'Ask Me Later', | ||
| buttonNegative: 'Cancel', | ||
| buttonPositive: 'OK' |
There was a problem hiding this comment.
We should localize these strings
|
@Ajeett01 We need to fix failing check on the latest commit |
Ajeett01
force-pushed
the
csv-export
branch
2 times, most recently
from
a03c80a
to
1ea2ac2
Compare
| ) | ||
| .join('\n'); | ||
|
|
||
| return `Transaction Section\n${header}\n${rows}`; |
| '', | ||
| '', | ||
| 'Expiry' | ||
| ].join(','); |
There was a problem hiding this comment.
these should be localized
| ].join(','); | ||
|
|
||
| const invoiceSection = [ | ||
| 'Invoice Section', |
| ].join('\n'); | ||
|
|
||
| const paymentSection = [ | ||
| 'Payment Section', |
| const { filteredActivity } = ActivityStore; | ||
|
|
||
| if (!startDate || !endDate) { | ||
| Alert.alert('Error', 'Please select Start and End date.'); |
| 'react-native-reanimated/plugin', | ||
| ['@babel/plugin-transform-export-namespace-from'] | ||
| ] |
There was a problem hiding this comment.
I am curious about this too
|
closing in favor of #2436 |
Description
Relates to issue: ZEUS-#1467