SendingLightning: Display payment paths after successful lightning payment #2345
Conversation
|
Maybe we should join the payment path and add note buttons on one line to save real estate. [Payment Path (3)] [Add Note] We'd have to test against low resolutions though. |
|
|
|
this is definitely better than before, but the margins are driving me nuts. We need to find a way to make sure everything lines up. We could also use less margins on top and bottom too for this row. |
shubhamkmr04
force-pushed
the
shubham/paths-in-success-view
branch
from
76cfdf1 to
9a2024d
Compare
|
@shubhamkmr04 can you provide screenshots if the layout has been changed at all? |
|
|
Tested on iPhone 15 pro for now |
views/SendingLightning.tsx
Outdated
|
|
||
| const enhancedPath = currentPayment?.enhancedPath; | ||
|
|
||
| const isPaymentPathExist = |
There was a problem hiding this comment.
nit: var name needs work, grammatically you probably wanted doesPaymentPathExist, but paymentPathExists may be better. Up to you.
There was a problem hiding this comment.
done, also fixed the bottom. Now looks good for android, small iPhones and iPad as well
#1927