[feature] Activity: CSV Export

[kaloudis]

Description

Relates to issue: ZEUS-1467

[myxmaster]

Nice work! A few thoughts:

1. Exported csv filename should start with something like Zeus_activity-export_... instead of data_....
2. Would "On-chain" and "Lightning" be more comprehensible than "Transaction" and "Payment"?
3. Either way, stick with singular (or plural) consequently (right now everything is singular, but 1st line in payment csv-file is "Payments").
4. Creation Date / Timestamp field contains , chars itself but also space chars after each , -> one of those should be removed before written to csv, otherwise post processing of csv data will create extra work.

[myxmaster]

Oh and what about exporting notes as well?

[myxmaster]

There are 2 commas before the timestamp (in both, ln and onchain csv):

Payments
Destination,Payment Hash,Value,Note,Creation Date
02a3eda67c8b28d94c01605b0b73f8b8d6f6905135bd9bf5e9c77b26be68658837,ca94af0cd8c58d509a75a0928d668d749c6a3813ea52a4701fbcd5b737fa6535,200000,,Thu Oct 24 2024 10:39:23 GMT+0000

Else, edge case for notes: they can contain a comma char itself. so we should export notes in qoutes: ""
Typically csv interpreters understand that and import it into 1 field then.

nit: the csv files still start with "Payments" vs. "Transaction"

[myxmaster]

Expiry in invoices.csv also has a comma, but I think we should export "Original Expiry" (e.g. 1 hour) anyways, not "Time until Expiry" (e.g. 59 minutes, 24 seconds).

Amount Paid (sat),Note,Creation Date,Expiry
21000,"Note, with comma",Thu Oct 31 2024 00:26:48 GMT+0000,59 minutes, 35 seconds

The 2 commas are still there (in case no note is exported).

[myxmaster]

My bad, the 2 commas totally make sense of course, because the data always has to match the headlines and in case there is no note the 2 commas will lead to an empty "note" field when importing the csv to e.g. Excel.

But you now put everything in quotes, not sure why, I think that is unneeded.

[kaloudis]

My bad, the 2 commas totally make sense of course, because the data always has to match the headlines and in case there is no note the 2 commas will lead to an empty "note" field when importing the csv to e.g. Excel.

But you now put everything in quotes, not sure why, I think that is unneeded.

Excel, Numbers etc should be able to grok out the values with quotes in place.

[kaloudis]

don't need to localize this if it's only used for console errors