Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTC amount formatting: Decimals: remove commas and add spaces #2526

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Nov 12, 2024

Description

This PR removes commas from Bitcoin amounts (namely on the KeypadPane view, and replaces them with spaces. The commas functionality was a bit broken. Spacing functionality is displayed correctly while allowing for better readability.

The PR also adds some checks to the KeypadPane so that Bitcoin's 21 million cap is not exceeded, replacing the arbitrary max limit we previously had.

Simulator.Screen.Recording.-.iPhone.16.Plus.-.2024-11-11.at.19.12.46.mp4

image

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added the Design Issue relating to design label Nov 12, 2024
@kaloudis kaloudis added this to the v0.9.3 milestone Nov 12, 2024
stores/FiatStore.ts Outdated Show resolved Hide resolved
@kaloudis kaloudis marked this pull request as ready for review November 13, 2024 02:15
@kaloudis kaloudis changed the title BTC amount formatting: remove commas and add spaces BTC amount formatting: Decimals: remove commas and add spaces Nov 13, 2024
@kaloudis kaloudis added the Refactor Code that needs to be refactored label Nov 13, 2024
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Issue relating to design Refactor Code that needs to be refactored
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants