Android: Graceful shutdown button in notification for persistent mode #2736
+165
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #2501.
#2735 has to be merged first.
Note:
As of Android 13, the OS gives users a way to stop Apps that are running in the background (see https://developer.android.com/develop/background-work/services/fgs/handle-user-stopping). Unfortunately that "Stop" button it not trying any graceful shutdown, but does a hard kill (tested with logging in
LndMobileService.java
). So we should provide a button on our own notification that will do a graceful shutdown. (Chances are low, but I guess it is not impossible to corrupt the db when doing a hard kill.)Changes:
-> translation cache will be updated at app start and when language is changed
-> bridged locale strings are defined in LocaleUtils.ts
Before:
This pull request is categorized as a:
Checklist
yarn run tsc
and made sure my code compiles correctlyyarn run lint
and made sure my code didn’t contain any problematic patternsyarn run prettier
and made sure my code is formatted correctlyyarn run test
and made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
yarn
after this PR is merged inpackage.json
andyarn.lock
have been properly updatedOther: