Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DS blocks table. #40

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Conversation

yaron-zilliqa
Copy link
Contributor

No description provided.

Copy link
Contributor

@rrw-zilliqa rrw-zilliqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than removing the code, can we hide this behind a developer flag please? Let's discuss in slack (and I can write an RFC if nec)

@yaron-zilliqa
Copy link
Contributor Author

Rather than removing the code, can we hide this behind a developer flag please? Let's discuss in slack (and I can write an RFC if nec)

Made this block conditional on a URL param called 'dev'. When set to 1 the recent DS blocks will be presented. Otherwise it will be hidden. The default is non-dev.

@yaron-zilliqa yaron-zilliqa force-pushed the 39-remove-recent-ds-blocks-table branch from 3dcf763 to 0174473 Compare June 21, 2024 10:40
mauromedda
mauromedda previously approved these changes Jun 24, 2024
@yaron-zilliqa yaron-zilliqa enabled auto-merge (squash) June 24, 2024 09:40
auto-merge was automatically disabled June 24, 2024 09:42

Pull request was closed

@yaron-zilliqa yaron-zilliqa reopened this Jun 24, 2024
@yaron-zilliqa yaron-zilliqa enabled auto-merge (squash) June 24, 2024 09:43
@yaron-zilliqa yaron-zilliqa self-assigned this Jun 24, 2024
Copy link
Contributor

@rrw-zilliqa rrw-zilliqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay - looks good to me :-)

@yaron-zilliqa yaron-zilliqa merged commit d1f768b into develop Jun 28, 2024
7 checks passed
@yaron-zilliqa yaron-zilliqa deleted the 39-remove-recent-ds-blocks-table branch June 28, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove recent DS blocks table which doesn't work with zq2
3 participants