Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blind signing and multiple transaction sending for legacy #12

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

abenso
Copy link
Collaborator

@abenso abenso commented Nov 4, 2024

No description provided.

Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment to understand better

app/src/apdu_handler_legacy.c Outdated Show resolved Hide resolved
Copy link
Member

@emmanuelm41 emmanuelm41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better if we catch the error with our macro, and set it to false directly there for any error that may happen? I know there is a macro like TRY/CATCH for that

@abenso
Copy link
Collaborator Author

abenso commented Nov 5, 2024

I prefer to use the catch block only for error handling and response formatting to avoid mixing concerns

@abenso abenso merged commit d26afc5 into main Nov 5, 2024
52 checks passed
@abenso abenso deleted the fix/blindsign branch November 5, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants