Malformed aria on Progress and Accordion #913

OlenaKashuba · 2023-07-19T16:25:10Z

Accordion: remove aria-label from wrapper
Progress: replace aria-label with aria-valuetext and add a label

github-actions · 2023-07-19T16:26:16Z

👋 Hey there!

Thank you for you contribution. Below is a preview of the release notes if your PR gets merged.
Please, make sure it includes all your significant changes with descriptive messages.
Keep in mind that release notes are automatically generated from the commit messages.
More info in the contribution section.

5.48.3 (2023-07-19)

Bug Fixes

accordion, progress: delete aria-label for non-interactive elements (9f68aad)
inputrange: add id to input range (fdeb39c)
progress: add hidden label for progress (138a9b7)

netlify · 2023-07-19T16:26:48Z

✅ Deploy Preview for zrc ready!

Name	Link
🔨 Latest commit	`138a9b7`
🔍 Latest deploy log	https://app.netlify.com/sites/zrc/deploys/64b80e68693c680008c59995
😎 Deploy Preview	https://deploy-preview-913--zrc.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2023-07-19T16:27:12Z

👋 Hey there!

Thank you for you contribution. Below is a preview of the release notes if your PR gets merged.
Please, make sure it includes all your significant changes with descriptive messages.
Keep in mind that release notes are automatically generated from the commit messages.
More info in the contribution section.

5.48.4 (2023-07-19)

Bug Fixes

accordion, progress: delete aria-label for non-interactive elements (9f68aad)
inputrange: add id to input range (fdeb39c)
progress: add hidden label for progress (138a9b7)

netlify · 2023-07-19T16:28:32Z

✅ Deploy Preview for zrc ready!

Name	Link
🔨 Latest commit	`48524c2`
🔍 Latest deploy log	https://app.netlify.com/sites/zrc/deploys/6570a9084a9daf0008e3e667
😎 Deploy Preview	https://deploy-preview-913--zrc.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2023-09-06T09:30:38Z

👋 Hey there!

Thank you for you contribution. Below is a preview of the release notes if your PR gets merged.
Please, make sure it includes all your significant changes with descriptive messages.
Keep in mind that release notes are automatically generated from the commit messages.
More info in the contribution section.

5.49.1 (2023-09-06)

Bug Fixes

accordion, progress: delete aria-label for non-interactive elements (9f68aad)
progress: add hidden label for progress (138a9b7)

admmasters · 2023-09-15T16:17:43Z

src/components/molecules/Progress/Progress.tsx

@@ -106,11 +116,13 @@ const Progress = ({ totalSteps, currentStep, withStep = false, progressColor, ..

  return (
    <ProgressWrapper>
+      <HiddenText id="in-progress">In progress</HiddenText>


Might want to make this overridable or it'll be quite easy to have multiple ids which are the same in the DOM.

we shouldn't have more than 1 progress bar on the page, no?

Sorry to hijack this thread, can someone approve this https://github.com/ZopaPublic/react-components/pull/936/files :D

In order to get out from being a maintainer you need to help us fix the checks :)

github-actions · 2023-10-25T13:28:30Z

👋 Hey there!

Thank you for you contribution. Below is a preview of the release notes if your PR gets merged.
Please, make sure it includes all your significant changes with descriptive messages.
Keep in mind that release notes are automatically generated from the commit messages.
More info in the contribution section.

5.49.1 (2023-10-25)

Bug Fixes

accordion, progress: delete aria-label for non-interactive elements (9f68aad)
progress: add hidden label for progress (138a9b7)

… into malformed-aria

github-actions · 2023-10-31T10:38:35Z

👋 Hey there!

Thank you for you contribution. Below is a preview of the release notes if your PR gets merged.
Please, make sure it includes all your significant changes with descriptive messages.
Keep in mind that release notes are automatically generated from the commit messages.
More info in the contribution section.

5.50.0 (2023-10-31)

Bug Fixes

accordion, progress: delete aria-label for non-interactive elements (9f68aad)
checkboxfield: fixed linting issues (e9a7817)
inappropriate aria use: inaproppriate aria use (b9f93fd)
progress: add hidden label for progress (138a9b7)
removed use of HiddenText when there is an errorMessage (43b58a0)

Features

added valid and errored states text (46f21d9)
new hiddentext component (f67f259)

github-actions · 2023-12-06T17:02:52Z

👋 Hey there!

Thank you for you contribution. Below is a preview of the release notes if your PR gets merged.
Please, make sure it includes all your significant changes with descriptive messages.
Keep in mind that release notes are automatically generated from the commit messages.
More info in the contribution section.

5.50.0 (2023-12-06)

Bug Fixes

accordion, progress: delete aria-label for non-interactive elements (9f68aad)
bump rollup plugin: bump rollup plugin (94212c3)
change repository url: change repository url (b380a38)
checkboxfield: fixed linting issues (e9a7817)
fortawesome pin versions: fortawesome pin versions (6af0f3c)
inappropriate aria use: inaproppriate aria use (b9f93fd)
new repo url: new repo url (f1abc0e)
pin react styleguidist: pin react styleguidist (de4e08b)
pnpm resolutions: pnpm resolutions (62059db)
pnpm version in ci: pnpm version in ci (9aa4779)
pnpm version: pnpm version 8.10.5 (ce2514b)
progress: add hidden label for progress (138a9b7)
removed use of HiddenText when there is an errorMessage (43b58a0)
revert package lock: revert package lock (f5ab852)
ts ignore carousel error: ts ignore carousel error (9ee2398)

Features

add role=status to alert for a11y (ac4f7aa)
add role=status to alert for a11y (e7a6445)
added valid and errored states text (46f21d9)
new hiddentext component (f67f259)

OlenaKashuba added 2 commits July 19, 2023 17:02

fix(accordion, progress): delete aria-label for non-interactive elements

9f68aad

fix(progress): add hidden label for progress

138a9b7

OlenaKashuba requested review from poteirard, moshie, katebeavis, raff-r, admmasters, matsoftware, TomGroombridge and khumbon as code owners July 19, 2023 16:25

Merge branch 'master' into malformed-aria

d597c91

Merge branch 'master' into malformed-aria

bb889ea

OlenaKashuba changed the title ~~Malformed aria on Progress and Accordion~~ Malformed aria on Progress Sep 6, 2023

OlenaKashuba changed the title ~~Malformed aria on Progress~~ Malformed aria on Progress and Accordion Sep 15, 2023

admmasters reviewed Sep 15, 2023

View reviewed changes

Merge branch 'master' into malformed-aria

22bacde

OlenaKashuba added 2 commits October 31, 2023 10:23

Merge branch 'master' of https://github.com/ZopaPublic/react-components…

3541b74

… into malformed-aria

fix(inappropriate aria use): inaproppriate aria use

b9f93fd

Merge branch 'master' into malformed-aria

48524c2

khumbon approved these changes Dec 6, 2023

View reviewed changes

charlielizzy merged commit 63ff8b8 into master Dec 6, 2023
7 checks passed

moshie deleted the malformed-aria branch January 23, 2024 15:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Malformed aria on Progress and Accordion #913

Malformed aria on Progress and Accordion #913

OlenaKashuba commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

netlify bot commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

netlify bot commented Jul 19, 2023 •

edited

Loading

github-actions bot commented Sep 6, 2023

admmasters Sep 15, 2023

OlenaKashuba Oct 18, 2023

poteirard Oct 31, 2023

OlenaKashuba Oct 31, 2023

github-actions bot commented Oct 25, 2023

github-actions bot commented Oct 31, 2023

github-actions bot commented Dec 6, 2023

Malformed aria on Progress and Accordion #913

Malformed aria on Progress and Accordion #913

Conversation

OlenaKashuba commented Jul 19, 2023

github-actions bot commented Jul 19, 2023

👋 Hey there!

5.48.3 (2023-07-19)

Bug Fixes

netlify bot commented Jul 19, 2023

✅ Deploy Preview for zrc ready!

github-actions bot commented Jul 19, 2023

👋 Hey there!

5.48.4 (2023-07-19)

Bug Fixes

netlify bot commented Jul 19, 2023 • edited Loading

✅ Deploy Preview for zrc ready!

github-actions bot commented Sep 6, 2023

👋 Hey there!

5.49.1 (2023-09-06)

Bug Fixes

admmasters Sep 15, 2023

Choose a reason for hiding this comment

OlenaKashuba Oct 18, 2023

Choose a reason for hiding this comment

poteirard Oct 31, 2023

Choose a reason for hiding this comment

OlenaKashuba Oct 31, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 25, 2023

👋 Hey there!

5.49.1 (2023-10-25)

Bug Fixes

github-actions bot commented Oct 31, 2023

👋 Hey there!

5.50.0 (2023-10-31)

Bug Fixes

Features

github-actions bot commented Dec 6, 2023

👋 Hey there!

5.50.0 (2023-12-06)

Bug Fixes

Features

netlify bot commented Jul 19, 2023 •

edited

Loading