-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/3.8.0 #132
Merged
Merged
Release/3.8.0 #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmResult<Success>` (#119)
* Completely revamped ASN.1 Tag Handling * Properly handle multi-byte tags * Introduce a new data structure `TLV.Tag` with an accompanying `TagClass` enum and a `constructed` flag to accurately represent arbitrary tags up to `ULong.MAX_VALUE` * Make all `tag` parameters `ULong` to reflect support for multi-byte tags * Remove `DERTags` * Revamp implicit tagging (there is still work to be done, but at least it supports CONSTRUCTED ASN.1 elements) * Refactor `Int.Companion.decodeFromDer()` -> `Int.Companion.decodeFromDerValue()` * Refactor `Long.Companion.decodeFromDer()` -> `Long.Companion.decodeFromDerValue()` * Introduce `ULong.toAsn1VarInt()` to encode ULongs into ASN.1 unsigned VarInts (**not to be confused with multi^2_base's`UVarInt`!**) * Introduce `decodeAsn1VarULong()` and `decodeAsn1VarUInt()` which can handle overlong inputs, as long as they start with a valid unsigned number encoding. * Comes in three ULong flavours: * `Iterator<Byte>.decodeAsn1VarULong()` * `Iterable<Byte>.decodeAsn1VarULong()` * `ByteArray.decodeAsn1VarULong()` * and three UInt flavours: * `Iterator<Byte>.decodeAsn1VarUInt()` * `Iterable<Byte>.decodeAsn1VarUInt()` * `ByteArray.decodeAsn1VarUInt()`
revamp and clean up implicit tagging. this closes #13
* Revamp `Asn1Element.parse()`, introducing new variants. This yields: * `Asn1Element.parse()` with the same semantics as before * `Asn1Element.parse()` alternative introduced, which takes a `ByteIterator` instead of a `ByteArray` * `Asn1Element.parseAll()` introduced, which consumes all bytes and returns a list of all ASN.1 elements (if parsing works) * Variant 1 takes a `ByteIterator` * Variant 2 takes a `ByteArray` * `Asn1Element.parseFirst()` introduced, which tries to only parse a single ASN.1 element from the input and leaves the rest untouched. * Variant 1 takes a `ByteIterator` and returns the element; the `ByteIterator` is advanced accordingly * Variant 2 takes a `ByteArray` and returns a `Pair` of `(element, remainingBytes)` * More consistent low-level encoding and decoding function names: * `encodeToAsn1Primitive` to produce an `Asn1Primitive` that can directly be DER-encoded * `encodeToAsn1ContentBytes` to produce the content bytes of a TLV primitive (the _V_ in TLV) * `decodeToXXX` to be invoked on an `Asn1Primitive` to decode a DER-encoded primitive into the target type * `decodeFromAsn1ContentBytes` to be invoked on the companion of the target type to decode the content bytes of a TLV primitive (the _V_ in TLV) * Update conventions -> Coroutines 1.0.9 --------- Co-authored-by: Jakob Heher <jakob.heher@iaik.tugraz.at>
iaik-jheher
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLV.Tag
with an accompanyingTagClass
enum and aconstructed
flag to accurately represent arbitrary tags up toULong.MAX_VALUE
tag
parametersULong
to reflect support for multi-byte tagsDERTags
Int.Companion.decodeFromDer
->Int.Companion.decodeFromDerValue()
Long.Companion.decodeFromDer
->Long.Companion.decodeFromDerValue()
ULong.Companion.decodeFromDer
which can handle overlong inputs, as long as they start with a valid ULong encodingVerifier::verify
fromKmmResult<Unit>
toKmmResult<Success>
. Usage is unchanged.ConfirmationClaim
to represent Proof-of-Possesion Key Semantics for JWTsJsonWebToken
to implement Demonstrating Proof of PossessionJsonWebToken.confirmationKey
byJsonWebToken.confirmationClaim
, the implementation was wrongULong.toAsn1VarInt()
to encode ULongs into ASN.1 unsigned VarInts (not to be confused withmulti^2_base's
UVarInt
!)decodeAsn1VarULong()
anddecodeAsn1VarUInt()
which can handle overlong inputs, as long as they start with a valid unsigned number encoding.Iterator<Byte>.decodeAsn1VarULong()
Iterable<Byte>.decodeAsn1VarULong()
ByteArray.decodeAsn1VarULong()
Iterator<Byte>.decodeAsn1VarUInt()
Iterable<Byte>.decodeAsn1VarUInt()
ByteArray.decodeAsn1VarUInt()
Asn1Element.parse()
, introducing new variants. This yields:Asn1Element.parse()
with the same semantics as beforeAsn1Element.parse()
alternative introduced, which takes aByteIterator
instead of aByteArray
Asn1Element.parseAll()
introduced, which consumes all bytes and returns a list of all ASN.1 elements (if parsing works)ByteIterator
ByteArray
Asn1Element.parseFirst()
introduced, which tries to only parse a single ASN.1 element from the input and leaves the rest untouched.ByteIterator
and returns the element; theByteIterator
is advanced accordinglyByteArray
and returns aPair
of(element, remainingBytes)
encodeToAsn1Primitive
to produce anAsn1Primitive
that can directly be DER-encodedencodeToAsn1ContentBytes
to produce the content bytes of a TLV primitive (the V in TLV)decodeToXXX
to be invoked on anAsn1Primitive
to decode a DER-encoded primitive into the target typedecodeFromAsn1ContentBytes
to be invoked on the companion of the target type to decode the content bytes of a TLV primitive (the V in TLV)runCatching
withcatching
to be extra-safe