Remove requirement from CSR to have certificate extensions #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesusMcCloud
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
can you reference the relevant rfc for me? |
|
There you go: https://datatracker.ietf.org/doc/html/rfc2986 I was not about to exclude you, it's just that I'm pretty sure @nodh knows more about this stuff than the both of us combined, so I was going for efficiency |
|
Then you might as well make the parameter optional? extensions: List<X509CertificateExtension>, |
nodh
approved these changes
Oct 8, 2024
|
your suggestion actually made me catch a bug, that now has a testcase for ;-) |
nodh
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #156